Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

Paul Moore
2015-07-17T02:42:48Z

On Thursday, July 16, 2015 10:01:28 PM Richard Guy Briggs wrote:
> On 15/07/16, Paul Moore wrote:
> > On Tuesday, July 14, 2015 11:50:26 AM Richard Guy Briggs wrote:
> > > Make this interface consistent with watch and filter key, avoiding the
> > > extra string copy and simply consume the new string pointer.
> > >
> > > Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> > > ---
> > >
> > > kernel/audit_exe.c | 8 ++++++--
> > > kernel/audit_fsnotify.c | 9 +--------
> > > kernel/auditfilter.c | 2 +-
> > > 3 files changed, 8 insertions(+), 11 deletions(-)
> >
> > Merge this patch too, there is no reason why these needs to be its own
> > patch.
> I wanted to keep this patch seperate until it is well understood and
> accepted rather than mix it in.
>
> I'm fine merging it if you prefer.

Like I mentioned in one of the patches, I'm not really a fan of how audit
handles the alloc/free'ing of some things, but I think it is more important to
be consistent within audit itself.

At some point we'll fix this, but it doesn't have to be now. Go ahead and
merge the patch with the others.

--
paul moore
security @ redhat