public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] silly ide without proc compile fix
@ 2001-11-29  0:00 Robert Love
  0 siblings, 0 replies; only message in thread
From: Robert Love @ 2001-11-29  0:00 UTC (permalink / raw)
  To: marcelo, andre; +Cc: linux-kernel

IDE subsystem fails to compile without proc support because
ide_remove_proc_entries is called but not defined.  Other uses of the
function are properly ifdef'ed, the following in ide-disk.c and
ide-floppy.c are not.

Please apply.

	Robert Love

diff -urN linux-2.4.17-pre1/drivers/ide/ide-disk.c linux/drivers/ide/ide-disk.c
--- linux-2.4.17-pre1/drivers/ide/ide-disk.c	Wed Nov 28 15:15:35 2001
+++ linux/drivers/ide/ide-disk.c	Wed Nov 28 17:05:07 2001
@@ -856,10 +856,12 @@
 			printk (KERN_ERR "%s: cleanup_module() called while still busy\n", drive->name);
 			failed++;
 		}
 		/* We must remove proc entries defined in this module.
 		   Otherwise we oops while accessing these entries */
+#ifdef CONFIG_PROC_FS
 		if (drive->proc)
 			ide_remove_proc_entries(drive->proc, idedisk_proc);
+#endif
 	}
 	ide_unregister_module(&idedisk_module);
 }
diff -urN linux-2.4.17-pre1/drivers/ide/ide-floppy.c linux/drivers/ide/ide-floppy.c
--- linux-2.4.17-pre1/drivers/ide/ide-floppy.c	Wed Nov 28 15:15:35 2001
+++ linux/drivers/ide/ide-floppy.c	Wed Nov 28 17:09:21 2001
@@ -2071,8 +2071,10 @@
 		}
 		/* We must remove proc entries defined in this module.
 		   Otherwise we oops while accessing these entries */
+#ifdef CONFIG_PROC_FS
 		if (drive->proc)
 			ide_remove_proc_entries(drive->proc, idefloppy_proc);
+#endif
 	}
 	ide_unregister_module(&idefloppy_module);
 }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2001-11-29  0:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-11-29  0:00 [PATCH] silly ide without proc compile fix Robert Love

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox