From: Robert Love <rml@tech9.net>
To: marcelo@conectiva.com.br
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] console close race fix resend
Date: 10 Dec 2001 20:51:51 -0500 [thread overview]
Message-ID: <1008035512.4287.1.camel@phantasy> (raw)
Marcelo,
[ Resend of previous patch, now against pre8. Note it (a) is a bug fix
and (b) was in Alan's tree ]
The attached is a fix originally by Andrew Morton and discovered by the
preempt-kernel patch. It is in Alan's tree but was never merged into
Linus's.
There is a race between con_close and con_flush_chars.
n_tty_receive_buf writes to the tty queue and then flushes it via
con_flush_chars. If the console closes in between these operations,
con_flush_char barfs.
Please, for all that is righteous, apply.
Robert Love
diff -urN linux-2.4.17-pre8/drivers/char/console.c linux/drivers/char/console.c
--- linux-2.4.17-pre8/drivers/char/console.c Thu Dec 6 14:08:14 2001
+++ linux/drivers/char/console.c Thu Dec 6 14:09:06 2001
@@ -2356,8 +2356,14 @@
return;
pm_access(pm_con);
+
+ /*
+ * If we raced with con_close(), `vt' may be null.
+ * Hence this bandaid. - akpm
+ */
acquire_console_sem();
- set_cursor(vt->vc_num);
+ if (vt)
+ set_cursor(vt->vc_num);
release_console_sem();
}
next reply other threads:[~2001-12-11 1:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-11 1:51 Robert Love [this message]
2001-12-11 3:16 ` [PATCH] console close race fix resend Gordon Oliver
2001-12-11 6:05 ` Robert Love
2001-12-11 6:28 ` Andrew Morton
2001-12-11 9:05 ` [PATCH] " Robert Love
2001-12-11 8:54 ` [PATCH] " Gordon Oliver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1008035512.4287.1.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox