* [PATCH] rtw88: check for validity before using pointer
@ 2021-12-23 17:51 Muhammad Usama Anjum
2021-12-24 0:28 ` Pkshih
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Usama Anjum @ 2021-12-23 17:51 UTC (permalink / raw)
To: Yan-Hsuan Chuang, Kalle Valo, David S. Miller, Jakub Kicinski,
Ping-Ke Shih, Po-Hao Huang,
open list:REALTEK WIRELESS DRIVER (rtw88),
open list:NETWORKING DRIVERS, open list
Cc: usama.anjum, kernel
ieee80211_probereq_get() can return NULL. Pointer skb should be checked
for validty before use.
Fixes: 10d162b2ed39 ("rtw88: 8822c: add ieee80211_ops::hw_scan")
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
drivers/net/wireless/realtek/rtw88/fw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
index 2f7c036f9022..0fc05a810d05 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.c
+++ b/drivers/net/wireless/realtek/rtw88/fw.c
@@ -1866,6 +1866,8 @@ static int rtw_hw_scan_update_probe_req(struct rtw_dev *rtwdev,
req->ssids[i].ssid,
req->ssids[i].ssid_len,
req->ie_len);
+ if (!skb)
+ return -ENOMEM;
rtw_append_probe_req_ie(rtwdev, skb, &list, rtwvif);
kfree_skb(skb);
}
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* RE: [PATCH] rtw88: check for validity before using pointer
2021-12-23 17:51 [PATCH] rtw88: check for validity before using pointer Muhammad Usama Anjum
@ 2021-12-24 0:28 ` Pkshih
0 siblings, 0 replies; 2+ messages in thread
From: Pkshih @ 2021-12-24 0:28 UTC (permalink / raw)
To: Muhammad Usama Anjum, Yan-Hsuan Chuang, Kalle Valo,
David S. Miller, Jakub Kicinski, Bernie Huang,
open list:REALTEK WIRELESS DRIVER (rtw88),
open list:NETWORKING DRIVERS, open list
Cc: kernel@collabora.com
> -----Original Message-----
> From: Muhammad Usama Anjum <usama.anjum@collabora.com>
> Sent: Friday, December 24, 2021 1:51 AM
> To: Yan-Hsuan Chuang <tony0620emma@gmail.com>; Kalle Valo <kvalo@kernel.org>; David S. Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Pkshih <pkshih@realtek.com>; Bernie Huang
> <phhuang@realtek.com>; open list:REALTEK WIRELESS DRIVER (rtw88) <linux-wireless@vger.kernel.org>; open
> list:NETWORKING DRIVERS <netdev@vger.kernel.org>; open list <linux-kernel@vger.kernel.org>
> Cc: usama.anjum@collabora.com; kernel@collabora.com
> Subject: [PATCH] rtw88: check for validity before using pointer
>
> ieee80211_probereq_get() can return NULL. Pointer skb should be checked
> for validty before use.
>
> Fixes: 10d162b2ed39 ("rtw88: 8822c: add ieee80211_ops::hw_scan")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> drivers/net/wireless/realtek/rtw88/fw.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
> index 2f7c036f9022..0fc05a810d05 100644
> --- a/drivers/net/wireless/realtek/rtw88/fw.c
> +++ b/drivers/net/wireless/realtek/rtw88/fw.c
> @@ -1866,6 +1866,8 @@ static int rtw_hw_scan_update_probe_req(struct rtw_dev *rtwdev,
> req->ssids[i].ssid,
> req->ssids[i].ssid_len,
> req->ie_len);
> + if (!skb)
> + return -ENOMEM;
> rtw_append_probe_req_ie(rtwdev, skb, &list, rtwvif);
> kfree_skb(skb);
> }
Without properly freeing skb(s) in list, it leads memory leak.
We need something below to free them:
if (!skb)
goto out;
[...]
out:
skb_queue_walk(&list, skb)
kfree_skb(skb);
return -ENOMEM;
So, NACK this patch.
--
Ping-Ke
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-24 0:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-23 17:51 [PATCH] rtw88: check for validity before using pointer Muhammad Usama Anjum
2021-12-24 0:28 ` Pkshih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox