public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Love <rml@tech9.net>
To: "David S. Miller" <davem@redhat.com>
Cc: kevin@koconnor.net, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: lock order in O(1) scheduler
Date: 10 Jan 2002 00:49:24 -0500	[thread overview]
Message-ID: <1010641765.5340.295.camel@phantasy> (raw)
In-Reply-To: <20020109.212957.59465864.davem@redhat.com>
In-Reply-To: <20020110001002.A13456@arizona.localdomain> <1010640369.5335.289.camel@phantasy>  <20020109.212957.59465864.davem@redhat.com>

On Thu, 2002-01-10 at 00:29, David S. Miller wrote:

> Unlocking order doesn't matter wrt. ABBA deadlock.

Indeed.  Thank you.

Anyhow, Ingo, here is a patch for the typo in set_cpus_allowed:

diff -urN linux-2.5.2-pre10/ linux/
--- linux-2.5.2-pre10/kernel/sched.c	Tue Jan  8 00:26:17 2002
+++ linux/kernel/sched.c	Thu Jan 10 00:41:38 2002
@@ -813,8 +813,8 @@
 		spin_lock_irq(&target_rq->lock);
 		spin_lock(&this_rq->lock);
 	} else {
-		spin_lock_irq(&target_rq->lock);
-		spin_lock(&this_rq->lock);
+		spin_lock_irq(&this_rq->lock);
+		spin_lock(&target_rq->lock);
 	}
 	dequeue_task(p, p->array);
 	this_rq->nr_running--;

	Robert Love


  reply	other threads:[~2002-01-10  5:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-10  5:10 lock order in O(1) scheduler kevin
2002-01-10  5:26 ` Robert Love
2002-01-10  5:29   ` David S. Miller
2002-01-10  5:49     ` Robert Love [this message]
2002-01-10  5:38   ` Davide Libenzi
2002-01-10  6:29   ` kevin
2002-01-10 13:11   ` Ingo Molnar
2002-01-10  5:51 ` Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1010641765.5340.295.camel@phantasy \
    --to=rml@tech9.net \
    --cc=davem@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox