From: Bongani Hlope <bonganilinux@mweb.co.za>
To: LKM <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@transmeta.com>
Subject: [PATCH] Compilation error on 2.5.10 linux-2.5/drivers/ide/pdc4030.c
Date: 10 Jan 2002 23:05:46 +0200 [thread overview]
Message-ID: <1010696751.5950.0.camel@localhost.localdomain> (raw)
This fixes an error when compiling and removes a unused variable warning
The following warning I'm not sure about though:
pdc4030.c: In function `do_pdc4030_io':
pdc4030.c:571: warning: control reaches end of non-void function
-Bongani
--- /usr/src/linux-2.5/drivers/ide/pdc4030.c Wed Jan 9 21:46:15 2002
+++ /usr/src/linux-2.5-dev/drivers/ide/pdc4030.c Thu Jan 10
22:50:29 2002
@@ -393,7 +393,6 @@
{
ide_hwgroup_t *hwgroup = HWGROUP(drive);
struct request *rq = hwgroup->rq;
- int i;
if (GET_STAT() & BUSY_STAT) {
if (time_before(jiffies, hwgroup->poll_timeout)) {
@@ -498,6 +497,7 @@
{
unsigned long timeout;
byte stat;
+ ide_startstop_t startstop;
/* Check that it's a regular command. If not, bomb out early. */
if (!(rq->flags & REQ_CMD)) {
@@ -543,7 +543,6 @@
break;
case WRITE:
- ide_startstop_t startstop;
OUT_BYTE(PROMISE_WRITE, IDE_COMMAND_REG);
/*
* Strategy on write is:
next reply other threads:[~2002-01-10 20:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-10 21:05 Bongani Hlope [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-01-11 9:01 [PATCH] Compilation error on 2.5.10 linux-2.5/drivers/ide/pdc4030.c Zwane Mwaikambo
2002-01-11 9:04 ` Andre Hedrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010696751.5950.0.camel@localhost.localdomain \
--to=bonganilinux@mweb.co.za \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox