From: Thomas Hood <jdthood@mail.com>
To: linux-kernel@vger.kernel.org
Cc: Stevie O <stevie@qrpff.net>, Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: apm.c and multiple battery slots
Date: 02 Feb 2002 08:30:59 -0500 [thread overview]
Message-ID: <1012656665.1379.15.camel@thanatos> (raw)
> I went to apm.c to look into patching it to support
> multiple batteries.
> I found this function:
> static int apm_get_battery_status(which, status, bat,
> life, nbat <- battery #)
> but it's #if 0'd out, and isn't referred to anywhere in the code.
> I looked at the changelog in the file to try to determine when
> it stopped being used, and why, but I found no useful information,
> and I can't even ask the person who did it, since they didn't
> tell me they did...
I am not the author, so the following is speculation.
My guess is that apm_get_battery_status() was written to
support multiple batteries (supported by APM 1.2 only) but
that the authors never got around to providing a user
interface to this functionality; so it remains ifdeffed out.
(Hence the function never "stopped" being used.)
The current official maintainer of the driver is Stephen Rothwell.
Stephen: How do you think the info about the second battery
might be furnished to the user?
--
Thomas
next reply other threads:[~2002-02-02 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-02 13:30 Thomas Hood [this message]
2002-02-02 21:23 ` apm.c and multiple battery slots Stevie O
-- strict thread matches above, loose matches on Subject: below --
2002-02-03 2:58 Thomas Hood
2002-02-03 6:53 ` Stevie O
2002-02-03 12:01 ` David Woodhouse
2002-02-02 4:58 Stevie O
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1012656665.1379.15.camel@thanatos \
--to=jdthood@mail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=stevie@qrpff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox