From: Robert Love <rml@tech9.net>
To: Alessandro Suardi <alessandro.suardi@oracle.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.4-pre6 fails to build on UP (sched.c)
Date: 10 Feb 2002 18:23:27 -0500 [thread overview]
Message-ID: <1013383408.6783.369.camel@phantasy> (raw)
In-Reply-To: <3C66F7C4.D559680D@oracle.com>
In-Reply-To: <3C66F7C4.D559680D@oracle.com>
On Sun, 2002-02-10 at 17:44, Alessandro Suardi wrote:
> It appears that global_irq_holder will only be seen from
> <asm/hardirq.h> if CONFIG_SMP is defined. I haven't dug
> deeper to see whether this is due to CONFIG_PREEMPT (to
> which I said 'Y') or not.
Indeed, there is a compile error if preemption is enabled but SMP is
not. I apologize. Fix is attached.
Robert Love
diff -urN linux-2.5.4-pre6/include/asm-i386/smplock.h linux/include/asm-i386/smplock.h
--- linux-2.5.4-pre6/include/asm-i386/smplock.h Sun Feb 10 15:35:55 2002
+++ linux/include/asm-i386/smplock.h Sun Feb 10 18:15:55 2002
@@ -15,6 +15,7 @@
#else
#ifdef CONFIG_PREEMPT
#define kernel_locked() preempt_get_count()
+#define global_irq_holder 0
#else
#define kernel_locked() 1
#endif
prev parent reply other threads:[~2002-02-10 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-10 22:44 2.5.4-pre6 fails to build on UP (sched.c) Alessandro Suardi
2002-02-10 23:23 ` Robert Love [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1013383408.6783.369.camel@phantasy \
--to=rml@tech9.net \
--cc=alessandro.suardi@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox