* [PATCH] 2.5.4 PREEMPT on UP x86 breakage
@ 2002-02-11 17:44 Mikael Pettersson
2002-02-11 20:10 ` Robert Love
0 siblings, 1 reply; 2+ messages in thread
From: Mikael Pettersson @ 2002-02-11 17:44 UTC (permalink / raw)
To: linux-kernel; +Cc: rml, roy, torvalds
In 2.5.4, CONFIG_PREEMPT breaks UP x86 kernels by triggering
the BUG in release_kernel_lock(), kernel/sched.c, line 664.
The patch below fixed it for me. It's a bit crude, but smp.h
doesn't export the #define if CONFIG_SMP is disabled.
/Mikael
--- linux-2.5.4/include/asm-i386/smplock.h.~1~ Mon Feb 11 12:21:46 2002
+++ linux-2.5.4/include/asm-i386/smplock.h Mon Feb 11 16:55:18 2002
@@ -15,7 +15,7 @@
#else
#ifdef CONFIG_PREEMPT
#define kernel_locked() preempt_get_count()
-#define global_irq_holder 0
+#define global_irq_holder 0xFF /* XXX: NO_PROC_ID */
#else
#define kernel_locked() 1
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 2.5.4 PREEMPT on UP x86 breakage
2002-02-11 17:44 [PATCH] 2.5.4 PREEMPT on UP x86 breakage Mikael Pettersson
@ 2002-02-11 20:10 ` Robert Love
0 siblings, 0 replies; 2+ messages in thread
From: Robert Love @ 2002-02-11 20:10 UTC (permalink / raw)
To: Mikael Pettersson; +Cc: linux-kernel, roy, torvalds
On Mon, 2002-02-11 at 12:44, Mikael Pettersson wrote:
> In 2.5.4, CONFIG_PREEMPT breaks UP x86 kernels by triggering
> the BUG in release_kernel_lock(), kernel/sched.c, line 664.
> The patch below fixed it for me. It's a bit crude, but smp.h
> doesn't export the #define if CONFIG_SMP is disabled.
This is indeed a proper change. Thank you,
Robert Love
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-02-11 20:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-02-11 17:44 [PATCH] 2.5.4 PREEMPT on UP x86 breakage Mikael Pettersson
2002-02-11 20:10 ` Robert Love
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox