[PATCH] 2.5: further llseek cleanup (3/3)

Manfred Spraul
2002-02-16T22:32:11Z

Hi Robert,

I think the pcilynx change is wrong:

> - if (newoffs < 0 || newoffs > PCILYNX_MAX_MEMORY + 1) return
> -EINVAL;
> + if (newoffs < 0 || newoffs > PCILYNX_MAX_MEMORY + 1) {
> + lock_kernel();
^^^^^^ unlock_kernel()?
> + return -EINVAL;
> + }
>
> file->f_pos = newoffs;
^^^^^^^^^^^^^^^^^^^ where is the unlock here?
> return newoffs;

--
Manfred