From: David Howells <dhowells@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: dhowells@redhat.com, Christoph Hellwig <hch@infradead.org>,
willy@infradead.org, dchinner@redhat.com,
Steve French <smfrench@gmail.com>,
Shyam Prasad N <nspmangalore@gmail.com>,
Rohith Surabattula <rohiths.msft@gmail.com>,
Jeff Layton <jlayton@kernel.org>, Ira Weiny <ira.weiny@intel.com>,
torvalds@linux-foundation.org, linux-cifs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
jlayton@redhat.com
Subject: Re: How to convert I/O iterators to iterators, sglists and RDMA lists
Date: Fri, 04 Nov 2022 18:47:23 +0000 [thread overview]
Message-ID: <1014264.1667587643@warthog.procyon.org.uk> (raw)
In-Reply-To: <67142.1666978314@warthog.procyon.org.uk>
David Howells <dhowells@redhat.com> wrote:
> > What protects pages involved in ITER_XARRAY iterator created by
> > afs_read_dir()? Note that we are not guaranteed inode_lock() on
> > the directory in question...
>
> Yeah - that needs fixing. The size of the data can change, but I don't update
> the iterator.
Actually, no. The iterator is the output buffer for afs_fetch_data(). If the
buffer turned out to be too small we drop the validate_lock and go round and
try again.
req->actual_len and req->file_size are updated by afs_fetch_data() from the
RPC reply. req->len tells the RPC delivery code how big the buffer is (which
we don't have to fill if there's less data available than we have buffer
space).
David
next prev parent reply other threads:[~2022-11-04 18:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 15:26 How to convert I/O iterators to iterators, sglists and RDMA lists David Howells
2022-10-17 13:15 ` Christoph Hellwig
2022-10-20 14:03 ` David Howells
2022-10-21 3:30 ` Ira Weiny
2022-10-24 14:51 ` Christoph Hellwig
2022-10-24 14:57 ` Christoph Hellwig
2022-10-24 19:53 ` Al Viro
2022-10-28 2:33 ` [PATCH v2 01/12] get rid of unlikely() on page_copy_sane() calls Al Viro
2022-10-28 2:33 ` [PATCH v2 02/12] csum_and_copy_to_iter(): handle ITER_DISCARD Al Viro
2022-10-28 2:33 ` [PATCH v2 03/12] [s390] copy_oldmem_kernel() - WRITE is "data source", not destination Al Viro
2022-10-28 2:33 ` [PATCH v2 04/12] [fsi] " Al Viro
2022-10-28 2:33 ` [PATCH v2 05/12] [infiniband] READ is "data destination", not source Al Viro
2022-10-28 2:33 ` [PATCH v2 06/12] [s390] zcore: WRITE is "data source", not destination Al Viro
2022-10-28 2:33 ` [PATCH v2 07/12] [s390] memcpy_real(): " Al Viro
2022-10-28 2:33 ` [PATCH v2 08/12] [target] fix iov_iter_bvec() "direction" argument Al Viro
2022-10-28 2:33 ` [PATCH v2 09/12] [vhost] fix 'direction' argument of iov_iter_{init,bvec}() Al Viro
2022-10-28 2:33 ` [PATCH v2 10/12] [xen] fix "direction" argument of iov_iter_kvec() Al Viro
2022-10-28 12:48 ` John Stoffel
2022-10-28 12:49 ` John Stoffel
2022-10-28 2:33 ` [PATCH v2 11/12] iov_iter: saner checks for attempt to copy to/from iterator Al Viro
2022-10-28 2:33 ` [PATCH v2 12/12] use less confusing names for iov_iter direction initializers Al Viro
2022-10-28 16:41 ` Linus Torvalds
2022-10-28 17:02 ` David Howells
2022-10-28 17:09 ` Linus Torvalds
2022-10-28 17:15 ` Al Viro
2022-10-28 18:35 ` Linus Torvalds
2022-10-28 19:30 ` Al Viro
2022-10-28 20:34 ` Linus Torvalds
2022-10-30 5:01 ` Al Viro
2022-10-30 8:12 ` [PATCH v2 01/12] get rid of unlikely() on page_copy_sane() calls Christoph Hellwig
2022-10-28 17:31 ` How to convert I/O iterators to iterators, sglists and RDMA lists David Howells
2022-11-04 18:47 ` David Howells [this message]
2022-11-01 13:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1014264.1667587643@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jlayton@kernel.org \
--cc=jlayton@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=rohiths.msft@gmail.com \
--cc=smfrench@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox