From: petter wahlman <petter@bluezone.no>
To: linux-kernel@vger.kernel.org
Cc: info@melware.de
Subject: [PATCH] 2.4.18 Eicon ISDN driver fix.
Date: 26 Feb 2002 20:26:18 +0100 [thread overview]
Message-ID: <1014679267.27236.6.camel@BadEip> (raw)
The following code is calling a possibly blocking operation while
holding a spinlock.
Petter Wahlman
--- linux-2.4.18/drivers/isdn/eicon/eicon_mod.c Fri Dec 21 18:41:54 2001
+++ linux-2.4.18-pw/drivers/isdn/eicon/eicon_mod.c Mon Feb 25
23:45:05 2002
@@ -665,8 +665,11 @@
else
cnt = skb->len;
- if (user)
+ if (user) {
+ spin_unlock_irqrestore(&eicon_lock,
flags);
copy_to_user(p, skb->data, cnt);
+ spin_lock_irqsave(&eicon_lock, flags);
+ }
else
memcpy(p, skb->data, cnt);
next reply other threads:[~2002-02-26 19:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-26 19:26 petter wahlman [this message]
2002-02-26 19:54 ` [PATCH] 2.4.18 Eicon ISDN driver fix Dave Jones
2002-02-26 19:49 ` petter wahlman
2002-02-26 20:50 ` Alan Cox
2002-02-27 7:58 ` Armin Schindler
2002-02-28 17:41 ` Marcelo Tosatti
2002-02-28 21:14 ` petter wahlman
2002-03-01 7:30 ` Armin Schindler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1014679267.27236.6.camel@BadEip \
--to=petter@bluezone.no \
--cc=info@melware.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox