public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Love <rml@tech9.net>
To: fisaksen@bewan.com
Cc: mitch@sfgoth.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spinlock not locked when unlocking in atm_dev_register
Date: 01 Mar 2002 17:15:48 -0500	[thread overview]
Message-ID: <1015020950.11295.25.camel@phantasy> (raw)
In-Reply-To: <20020301163936.7FA725F963@postfix2-2.free.fr>
In-Reply-To: <20020301163936.7FA725F963@postfix2-2.free.fr>

On Fri, 2002-03-01 at 12:46, Frode Isaksen wrote:
> If you compile the kernel with SMP and spinlock debugging, BUG() will be 
> called when registering your atm driver, since the "atm_dev_lock" spinlock is 
> not locked when unlocking it.

I don't have any knowledge of the source in question, but wouldn't a
possibility (perhaps even more likely) be that you should _add_ the
spin_lock instead of remove the spin_unlocks ?

	Robert Love


  reply	other threads:[~2002-03-01 22:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-01 17:46 [PATCH] spinlock not locked when unlocking in atm_dev_register Frode Isaksen
2002-03-01 22:15 ` Robert Love [this message]
2002-03-04  8:29   ` Frode Isaksen
2002-03-04 18:58     ` Robert Love
2002-03-01 22:32 ` Maksim Krasnyanskiy
2002-03-01 22:35   ` Robert Love
2002-03-01 22:38     ` David S. Miller
2002-03-01 22:48     ` How to get kernel data using /proc system? Lei Wang
2002-03-02  0:28     ` [PATCH] spinlock not locked when unlocking in atm_dev_register Maksim Krasnyanskiy
2002-03-01 23:06   ` Mitchell Blank Jr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1015020950.11295.25.camel@phantasy \
    --to=rml@tech9.net \
    --cc=fisaksen@bewan.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitch@sfgoth.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox