From: Robert Love <rml@tech9.net>
To: Andrey Panin <pazke@orbita1.ru>
Cc: Andries.Brouwer@cwi.nl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] swapfile.c
Date: 04 Mar 2002 13:48:08 -0500 [thread overview]
Message-ID: <1015267692.15277.13.camel@phantasy> (raw)
In-Reply-To: <20020304112824.GA279@pazke.ipt>
In-Reply-To: <UTC200203022125.VAA144817.aeb@cwi.nl> <20020304112824.GA279@pazke.ipt>
On Mon, 2002-03-04 at 06:28, Andrey Panin wrote:
> On Сбт, Мар 02, 2002 at 09:25:16 +0000, Andries.Brouwer@cwi.nl wrote:
> > In 2.5.2 swapfile.c was broken:
> > In sys_swapon() we see
> >
> > swap_file = filp_open(name, O_RDWR, 0);
> > if (IS_ERR(swap_file))
> > goto bad_swap_2;
> >
> > bad_swap_2:
> > ...
> > if (swap_file)
> > filp_close(swap_file, NULL);
> >
> > and this oopses the kernel.
>
> Fixed in -dj tree.
Eww, nice spotting Andries. If it is in the -dj tree, someone want to
push that bit to Linus?
Robert Love
next prev parent reply other threads:[~2002-03-04 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-02 21:25 [PATCH] swapfile.c Andries.Brouwer
2002-03-04 11:28 ` Andrey Panin
2002-03-04 18:48 ` Robert Love [this message]
2002-03-04 19:14 ` Dave Jones
-- strict thread matches above, loose matches on Subject: below --
2001-06-20 0:24 [Patch] swapfile.c Nathan D. Fabian
2001-06-20 15:16 ` Nathan D. Fabian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1015267692.15277.13.camel@phantasy \
--to=rml@tech9.net \
--cc=Andries.Brouwer@cwi.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@orbita1.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox