From: Robert Love <rml@tech9.net>
To: Frode Isaksen <fisaksen@bewan.com>
Cc: mitch@sfgoth.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spinlock not locked when unlocking in atm_dev_register
Date: 04 Mar 2002 13:58:33 -0500 [thread overview]
Message-ID: <1015268314.15479.32.camel@phantasy> (raw)
In-Reply-To: <B8A8EEF6.E8B%fisaksen@bewan.com>
In-Reply-To: <B8A8EEF6.E8B%fisaksen@bewan.com>
On Mon, 2002-03-04 at 03:29, Frode Isaksen wrote:
> The atm_dev_register function is calling functions that are using the same
> spinlock, so you cannot just lock the spinlock when entering the function..
Ah, OK -- my apologies. Then, a few things need to be checked:
- atm_dev_register (ignoring its callees) does not need a lock
- every callee of atm_dev_register that does need the lock
acquires and releases it itself (this is good design, too)
I suspect the second point may be missing the releases in cases, since
those spin_unlocks were in the code.
Robert Love
next prev parent reply other threads:[~2002-03-04 18:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-01 17:46 [PATCH] spinlock not locked when unlocking in atm_dev_register Frode Isaksen
2002-03-01 22:15 ` Robert Love
2002-03-04 8:29 ` Frode Isaksen
2002-03-04 18:58 ` Robert Love [this message]
2002-03-01 22:32 ` Maksim Krasnyanskiy
2002-03-01 22:35 ` Robert Love
2002-03-01 22:38 ` David S. Miller
2002-03-01 22:48 ` How to get kernel data using /proc system? Lei Wang
2002-03-02 0:28 ` [PATCH] spinlock not locked when unlocking in atm_dev_register Maksim Krasnyanskiy
2002-03-01 23:06 ` Mitchell Blank Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1015268314.15479.32.camel@phantasy \
--to=rml@tech9.net \
--cc=fisaksen@bewan.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch@sfgoth.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox