From: Robert Love <rml@tech9.net>
To: Andrew Morton <akpm@zip.com.au>
Cc: Adrian Bunk <bunk@fs.tum.de>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: aa-160-lru_release_check
Date: 20 Mar 2002 15:42:38 -0500 [thread overview]
Message-ID: <1016656959.15333.35.camel@phantasy> (raw)
In-Reply-To: <3C98E2E4.A42B13D0@zip.com.au>
On Wed, 2002-03-20 at 14:28, Andrew Morton wrote:
> I hate BUG_ON() :) It's arse-about so you have to stare at it furiously
> to understand why your kernel still works.
>
> I hope the Nobel committee is reading this mailing list: how
> about assert()?
I have a patch that introduces BUG_ON for 2.4. I like the idea of
BUG_ON and it is certainly a place where the unlikely bit is useful.
I've posted the patch here before; I was going to do so again against
the next 2.4-pre.
Further, and most importantly, the patch provides compatibility with 2.5
code that uses it. I have no problems naming BUG_ON anything anyone
wants (Jeff's suggestion of kassert seems sane) but we should then do
the proper renaming in 2.5.
Robert Love
prev parent reply other threads:[~2002-03-20 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-20 4:01 aa-160-lru_release_check Andrew Morton
2002-03-20 16:09 ` aa-160-lru_release_check Adrian Bunk
2002-03-20 19:16 ` aa-160-lru_release_check Mike Fedyk
2002-03-20 19:28 ` aa-160-lru_release_check Andrew Morton
2002-03-20 19:38 ` aa-160-lru_release_check Jeff Garzik
2002-03-20 20:02 ` aa-160-lru_release_check Dave Jones
2002-03-20 20:42 ` Robert Love [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1016656959.15333.35.camel@phantasy \
--to=rml@tech9.net \
--cc=akpm@zip.com.au \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox