From: Robert Love <rml@tech9.net>
To: "Ishan O. Jayawardena" <ioshadij@hotmail.com>
Cc: akpm@zip.com.au, linux-kernel@vger.kernel.org
Subject: Re: [patch] kjournald locking fix
Date: 04 Apr 2002 13:40:22 -0500 [thread overview]
Message-ID: <1017945626.22299.475.camel@phantasy> (raw)
In-Reply-To: <Pine.LNX.4.21.0204041539260.572-200000@shalmirane.net>
On Thu, 2002-04-04 at 17:02, Ishan O. Jayawardena wrote:
>
> Greetings,
>
> kjournald seems to be missing an unlock_kernel() for a matching
> lock_kernel(). A posting by Dennis Vadura to l-k mentions (among other
> things) a kernel message that says kjournald exited with preempt_count ==
> 1. The attached patch (text/plain) adds the necessary
> unlock_kernel(). [But I haven't been able to reproduce the hang that
> Dennis experiences...]
> Tested only on UP. Patch is for 2.4.19-pre5 + prempt-kernel, _no_
> lock-break. I hope the positioning of unlock_kernel() is correct... please
> correct me if I'm wrong.
The unlock_kernel is correct, thanks.
In this case, the messae about the nonzero preempt_count is not a
problem - kjournald just exits without dropping the BKL because it knows
schedule will do it for you. It is cleaner, however, to explicitly
relinquish the lock, and it removes the preempt_count debug whining.
So the patch is good - thanks,
Robert Love
next prev parent reply other threads:[~2002-04-04 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-04 22:02 [patch] kjournald locking fix Ishan O. Jayawardena
2002-04-04 10:19 ` Andrew Morton
2002-04-04 18:40 ` Robert Love [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-04-04 22:55 Ishan O. Jayawardena
2002-04-04 18:40 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1017945626.22299.475.camel@phantasy \
--to=rml@tech9.net \
--cc=akpm@zip.com.au \
--cc=ioshadij@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox