From: Robert Love <rml@tech9.net>
To: Pavel Machek <pavel@suse.cz>
Cc: dipankar@in.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: 2.5.8: preemption + SMP broken ?
Date: 22 Apr 2002 14:16:30 -0400 [thread overview]
Message-ID: <1019499391.934.9.camel@phantasy> (raw)
In-Reply-To: <20020421185705.B155@toy.ucw.cz>
On Sun, 2002-04-21 at 14:57, Pavel Machek wrote:
> Wel, if race is in migration code, you should fix migration, not add
> preempt_disable(), right? [Or is race preempt-onlly?]
I was not sure where the race was - I really did not see a preempt-only
race there, but I could not pinpoint the cause for an SMP race. Since
it was only showing itself as a preempt-related race, I disabled
preemption.
Erich Focht later pointed out that interrupts should be disabled in
migration_init and we sent a patch off to Linus. I will do some testing
and see if this fixes it (I suspect it may) and subsequently remove the
preempt code.
Robert Love
prev parent reply other threads:[~2002-04-22 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-17 17:52 2.5.8: preemption + SMP broken ? Dipankar Sarma
2002-04-17 18:25 ` Robert Love
2002-04-17 19:04 ` Dipankar Sarma
2002-04-21 18:57 ` Pavel Machek
2002-04-22 18:16 ` Robert Love [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1019499391.934.9.camel@phantasy \
--to=rml@tech9.net \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox