From: Keith Owens <kaos@ocs.com.au>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.4.19-pre6 standardize {aic7xxx,aicasm}/Makefile
Date: Thu, 11 Apr 2002 10:04:47 +1000 [thread overview]
Message-ID: <10197.1018483487@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "Wed, 10 Apr 2002 21:52:57 +0200." <3CB49819.140EEC01@linux-m68k.org>
On Wed, 10 Apr 2002 21:52:57 +0200,
Roman Zippel <zippel@linux-m68k.org> wrote:
>Keith Owens wrote:
>
>> foo_files := $(srcfile foo-gen) $(srcfile foo.out_shipped)
>> $(objfile foo_sum.d): $(srcfile foo_sum) $(foo_files)
>
>Why don't we use a script like this:
>
>set -e
>src=$1
>dst=$2
>shift 2
>
>test -f $dst && tail -1 $dst | sed 's,/\* \(.*\) \*/,\1,' | md5sum -c &&
>touch $dst && exit 0
>echo "$@"
>"$@"
>echo "/* $(md5sum $src) */" >> $dst
>
>Then just call it with:
> <script> <src> <dst> <build command>
>
>This is much simpler and also it also gets rid of these small checksum
>files.
There can be multiple destination files, e.g. running yacc produces a
.c and a .h file.
The generated file is not necessarily .[ch], wrapping the md5sum in
/* */ may break some generated files. AFAIK all currently generated
files are .[ch] but I do not want to restrict future builds.
The output can change without the inputs changing. For example, the
distributor might find a bug in the tool that generates the file,
install a new version of the tool and regenerate. The inputs have not
changed but the output has. To detect this, the md5sum is across all
files, including the outputs, which makes it impossible to store the
sum in one of the output files.
Unlikely I know, but I want 100% coverage on these special cases. 90%
reliability on a kernel build was acceptable when everybody was an
expert, but not now that the population of kernel builders is in the
tens of thousands. There are far too many build problems where the
response is "make mrproper", because of the special cases that fail.
next prev parent reply other threads:[~2002-04-11 0:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-06 10:06 [patch] 2.4.19-pre6 standardize {aic7xxx,aicasm}/Makefile Keith Owens
2002-04-06 19:58 ` Justin T. Gibbs
2002-04-06 23:00 ` Keith Owens
2002-04-08 2:51 ` Justin T. Gibbs
2002-04-08 3:54 ` Keith Owens
2002-04-08 4:27 ` Justin T. Gibbs
2002-04-10 2:41 ` Keith Owens
2002-04-10 15:52 ` Justin T. Gibbs
2002-04-10 19:52 ` Roman Zippel
2002-04-11 0:04 ` Keith Owens [this message]
2002-04-11 12:42 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10197.1018483487@ocs3.intra.ocs.com.au \
--to=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox