* [PATCH] [2.4] [2.5] Fix PPPoATM crash on disconnection (tasklet_disable; kfree(tasklet))
@ 2002-05-11 19:19 Luca Barbieri
0 siblings, 0 replies; only message in thread
From: Luca Barbieri @ 2002-05-11 19:19 UTC (permalink / raw)
To: Linus Torvalds, Marcelo Tosatti; +Cc: mitch, linux-kernel, linux-ppp
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
PPPoATM uses tasklet_disable() on a tasklet inside a struct and then
frees the struct, leaving a pointer to the freed tasklet inside tasklet
lists.
This patch replaces tasklet_disable() with tasklet_kill().
This bug is present in both 2.4.18 and 2.5.15 (and the patch applies to
both).
--- linux-old/net/atm/pppoatm.c Wed Apr 10 14:37:34 2002
+++ linux/net/atm/pppoatm.c Fri May 10 21:56:28 2002
@@ -125,7 +125,7 @@
pvcc = atmvcc_to_pvcc(atmvcc);
atmvcc->push = pvcc->old_push;
atmvcc->pop = pvcc->old_pop;
- tasklet_disable(&pvcc->wakeup_tasklet);
+ tasklet_kill(&pvcc->wakeup_tasklet);
ppp_unregister_channel(&pvcc->chan);
atmvcc->user_back = NULL;
kfree(pvcc);
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 232 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-05-11 19:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-05-11 19:19 [PATCH] [2.4] [2.5] Fix PPPoATM crash on disconnection (tasklet_disable; kfree(tasklet)) Luca Barbieri
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox