public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ron Gage <ron@rongage.org>
To: linux-kernel@vger.kernel.org
Subject: [PATCH][RFQ] - Kernel Janitor Project - Compiler Cleanups
Date: 19 May 2002 12:46:23 -0400	[thread overview]
Message-ID: <1021826787.7867.32.camel@portable> (raw)

Hi folks:

In my delusional attempt to contribute to the Linux Kernel, I have
chosen the "clean up compiler warnings" item from the Kernel Janitors
list.  This cleanup applies to base 2.4.18.

To expose the warnings, all one needs to do is change the CC defination
from "gcc" to "gcc -w" in the toplevel Makefile.

The typical warnings exposed are:
signed vs unsigned comparison
unsigned compared to negative constant
unused parameters
unused variables
missing initializers

While there has been some limited discussion (thanks Keith Owens)
regarding if GCC is doing the right thing wrt initializing structures,
the fact remains that if GCC is emitting a warning, then I did what I
could to squash it.  I am usign GCC v2.95.3 as distributed with
Slackware 8.0.

This patch touches a LOT of different files in the include, kernel,
drivers/block, drivers/acpi, and drivers/char directories and while the
changes should be benign, you are advised to handle with care.

This patch is a work in progress so expect more in the future from me. 
I am releasing what I have now for commentary and if necessary, course
correction.  PLEASE be gentle in the commentary as this is my first
major contribution to the kernel.

The patch, at 42k gzip'ed, is sitting on my webserver: 
http://www.rongage.org/2.4.18-rg1-diff.gz

Thanks!

Ron Gage - Saginaw, MI
(ron@rongage.org)



             reply	other threads:[~2002-05-19 16:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-19 16:46 Ron Gage [this message]
2002-05-24  8:06 ` [PATCH][RFQ] - Kernel Janitor Project - Compiler Cleanups Riley Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1021826787.7867.32.camel@portable \
    --to=ron@rongage.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox