From: Dan Murphy <dmurphy@ti.com>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>,
<jacek.anaszewski@gmail.com>, <pavel@ucw.cz>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<tomi.valkeinen@ti.com>
Subject: Re: [PATCH 2/2] leds: tlc591xx: Use the OF version of the LED registration function
Date: Mon, 1 Jul 2019 10:36:34 -0500 [thread overview]
Message-ID: <102194fe-e4d1-fa36-16f7-2a933e646bb5@ti.com> (raw)
In-Reply-To: <20190701152602.31716-3-jjhiblot@ti.com>
JJ
On 7/1/19 10:26 AM, Jean-Jacques Hiblot wrote:
> The driver parses the device-tree to identify which LED should be handled.
> Since the information about the device node is known at this time, we can
> provide the LED core with it. It may be useful later.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
> drivers/leds/leds-tlc591xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
> index 14e47ff44df5..6a2936c94b73 100644
> --- a/drivers/leds/leds-tlc591xx.c
> +++ b/drivers/leds/leds-tlc591xx.c
> @@ -207,7 +207,7 @@ tlc591xx_probe(struct i2c_client *client,
> led->led_no = idx++;
> led->ldev.brightness_set_blocking = tlc591xx_brightness_set;
> led->ldev.max_brightness = LED_FULL;
> - err = devm_led_classdev_register(dev, &led->ldev);
> + err = devm_of_led_classdev_register(dev, child, &led->ldev);
> if (err < 0) {
> dev_err(dev, "couldn't register LED %s\n",
> led->ldev.name);
Reviewed-by: Dan Murphy <dmurphy@ti.com>
next prev parent reply other threads:[~2019-07-01 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 15:26 [PATCH 0/2] leds: tlc591xx: switch to OF and managed API Jean-Jacques Hiblot
2019-07-01 15:26 ` [PATCH 1/2] leds: tlc591xx: simplify driver by using the managed led API Jean-Jacques Hiblot
2019-07-01 15:35 ` Dan Murphy
2019-07-05 10:17 ` Pavel Machek
2019-07-01 15:26 ` [PATCH 2/2] leds: tlc591xx: Use the OF version of the LED registration function Jean-Jacques Hiblot
2019-07-01 15:36 ` Dan Murphy [this message]
2019-07-05 20:24 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=102194fe-e4d1-fa36-16f7-2a933e646bb5@ti.com \
--to=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jjhiblot@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox