From: john stultz <johnstul@us.ibm.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH] Disable TSCs on CONFIG_MULTIQUAD
Date: 29 May 2002 17:20:54 -0700 [thread overview]
Message-ID: <1022718054.1963.51.camel@cog> (raw)
In-Reply-To: <1022712736.9255.289.camel@irongate.swansea.linux.org.uk>
> Add CONFIG_X86_TSC_NOT_SYNCHRONOUS or similar and then check
>
> #if defined(CONFIG_X86_TSC) && !defined(CONFIG_X86_NOT_SYNCHRONOUS))
<laugh> I guess I asked for it. :) I actually implemented something
similar to the above earlier, and was convinced out of it. The trade off
with this method is that while it simplifies the config.in changes, it
complicates the 12 or so #ifdef CONFIG_X86_TSC lines.
Keeping the "multi-quad TSCs are broken" fact in just one place
(config.in), rather then spread about the tree in precompiler
statements, seems like the best choice to me. I was actually hoping
there was a good config.in trick for turning CONFIG_X86_TSC off after it
had already been turned on, rather then adding a meta-option, but I'm
guessing there isn't.
Anyway, if you really would rather see what you suggested, I'll happily
change it (I do like the idea of breaking the CONFIG_X86_TSC_UNSYNCED
notion out of CONFIG_MULTIQUAD).
Thanks for the feedback!
-john
next prev parent reply other threads:[~2002-05-30 0:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-29 20:40 [RFC] [PATCH] Disable TSCs on CONFIG_MULTIQUAD john stultz
2002-05-29 22:52 ` Alan Cox
2002-05-30 0:20 ` john stultz [this message]
2002-05-30 1:37 ` Alan Cox
2002-05-30 0:54 ` Martin J. Bligh
2002-05-30 1:36 ` john stultz
2002-05-30 18:50 ` john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1022718054.1963.51.camel@cog \
--to=johnstul@us.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox