Re: [RFC] iput() cleanup (was Re: [patch 12/16] fix race between writeback and unlink)

Andreas Dilger
2002-06-03T16:28:19Z

On Jun 02, 2002 21:27 -0700, Linus Torvalds wrote:
> This is a first cut at cleaning up "iput()" and getting rid of some of the
> magic VFS-level behaviour of the i_nlink field which many filesystems do
> not actually want - as shown by the number of "force_delete" users out
> there.
>
> It does not change any real behaviour, but it splits up the "iput()"
> behaviour into several functions ("common_delete_inode()",
> "common_forget_inode()" and "common_drop_inode()"), and adds a place for a
> low-level filesystem to hook into the behaviour at inode drop time,
> through the "drop_inode" superblock operation.

If I had one minor note it would be to rename "common_*()" to "generic_*()"
to match the other VFS helper routines.

Cheers, Andreas
--
Andreas Dilger