From: Robert Love <rml@tech9.net>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au,
Peter Chubb <peter@chubb.wattle.id.au>
Subject: Re: [PATCH] Fix sys_capset in 2.5.20+patches...
Date: 05 Jun 2002 19:18:46 -0700 [thread overview]
Message-ID: <1023329932.917.421.camel@sinai> (raw)
In-Reply-To: <15614.50117.861698.205543@wombat.chubb.wattle.id.au>
On Wed, 2002-06-05 at 19:07, Peter Chubb wrote:
> The current head-of-bk-tree 2.5 kernel breaks capset() (and so
> named, for one, won't run). SYS_setcap() will *always* return -EINVAL
> with the current tree.
Ugh, do I really need braces there???
(there is another occurrence of this, too... brown paper bag me)
Linus, please apply this patch. Against 2.5-bk...
Robert Love
--- linux-2.5.20/kernel/capability.c Wed Jun 5 19:16:11 2002
+++ linux/kernel/capability.c Wed Jun 5 19:15:49 2002
@@ -39,13 +39,14 @@
if (get_user(version, &header->version))
return -EFAULT;
- if (version != _LINUX_CAPABILITY_VERSION)
+ if (version != _LINUX_CAPABILITY_VERSION) {
if (put_user(_LINUX_CAPABILITY_VERSION, &header->version))
return -EFAULT;
return -EINVAL;
+ }
if (get_user(pid, &header->pid))
- return -EFAULT;
+ return -EFAULT;
if (pid < 0)
return -EINVAL;
@@ -134,10 +135,11 @@
if (get_user(version, &header->version))
return -EFAULT;
- if (version != _LINUX_CAPABILITY_VERSION)
+ if (version != _LINUX_CAPABILITY_VERSION) {
if (put_user(_LINUX_CAPABILITY_VERSION, &header->version))
return -EFAULT;
return -EINVAL;
+ }
if (get_user(pid, &header->pid))
return -EFAULT;
prev parent reply other threads:[~2002-06-06 2:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-06 2:07 [PATCH] Fix sys_capset in 2.5.20+patches Peter Chubb
2002-06-06 2:18 ` Robert Love [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1023329932.917.421.camel@sinai \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@chubb.wattle.id.au \
--cc=torvalds@transmeta.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox