public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: Dave Jones <davej@suse.de>
Cc: marcelo@conectiva.com.br, lkml <linux-kernel@vger.kernel.org>,
	"Martin J. Bligh" <Martin.Bligh@us.ibm.com>
Subject: Re: [Patch] tsc-disable_A5
Date: 14 Jun 2002 12:04:18 -0700	[thread overview]
Message-ID: <1024081458.29928.148.camel@cog> (raw)
In-Reply-To: <20020614205751.U16772@suse.de>

On Fri, 2002-06-14 at 11:57, Dave Jones wrote:
> -#ifndef CONFIG_X86_TSC
> +#if !defined(CONFIG_X86_TSC)||defined(CONFIG_TSC_DISABLE)
> +#ifdef CONFIG_TSC_DISABLE
> +static int tsc_disable __initdata = 1;
> +#else /*CONFIG_TSC_DISABLE*/
>  static int tsc_disable __initdata = 0;
> +#endif /*CONFIG_TSC_DISABLE*/
> 
> This looks *really horrible*

True, I agree here. 

> Why not just unset CONFIG_X86_TSC for those machines ?

I was actually hoping for a suggestion like this when I posted this
patch earlier. Can one really just unset CONFIG_ options that have
previously been set? I'd actually prefer this, but doing so generated a
.config that looked like:

CONFIG_X86_TSC=y
...
# CONFIG_X86_TSC is not set

So I assumed CONFIG_X86_TSC would still hold. Am I wrong, or is there
another way to do this?

Thanks
-john



  reply	other threads:[~2002-06-14 19:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-14 18:35 [Patch] tsc-disable_A5 john stultz
2002-06-14 18:53 ` Benjamin LaHaise
2002-06-18  0:48   ` Kurt Garloff
2002-06-18  1:31     ` john stultz
2002-06-14 18:57 ` Dave Jones
2002-06-14 19:04   ` john stultz [this message]
2002-06-14 19:56     ` Dave Jones
2002-06-14 23:29       ` Kai Germaschewski
2002-06-14 23:44         ` john stultz
2002-06-24  2:09 ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2002-06-14 21:53 Mikael Pettersson
2002-06-14 22:11 ` john stultz
2002-06-15 14:13 Mikael Pettersson
2002-06-19 13:58 ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1024081458.29928.148.camel@cog \
    --to=johnstul@us.ibm.com \
    --cc=Martin.Bligh@us.ibm.com \
    --cc=davej@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox