From: Robert Love <rml@tech9.net>
To: Ingo Molnar <mingo@elte.hu>
Cc: Dave Jones <davej@suse.de>,
Linux Kernel <linux-kernel@vger.kernel.org>,
James Bottomley <James.Bottomley@SteelEye.com>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [patch] scheduler bits from 2.5.23-dj1
Date: 19 Jun 2002 16:47:00 -0700 [thread overview]
Message-ID: <1024530423.917.21.camel@sinai> (raw)
In-Reply-To: <Pine.LNX.4.44.0206200123470.25434-100000@e2>
On Wed, 2002-06-19 at 16:35, Ingo Molnar wrote:
> the scheduler optimisation in 2.5.23-dj1, from James Bottomley, look fine
> to me. I did some modifications:
Nice.
> +static inline unsigned int task_cpu(struct task_struct *p)
> +static inline unsigned int set_task_cpu(struct task_struct *p, unsigned int cpu)
Technically, shouldn't we make these `unsigned long' ?
I know on x86 we store cpu as a `u32' so it does not matter per se, but
in reality it is an unsigned long and other architectures may export it
as such.
Further, we compare and set it against the various CPU bitmaps and they
are all `unsigned long' and we do shifts against 1UL ...
Robert Love
next prev parent reply other threads:[~2002-06-19 23:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-19 11:23 Linux 2.5.23-dj1 Dave Jones
2002-06-19 23:36 ` [patch] scheduler bits from 2.5.23-dj1 Ingo Molnar
2002-06-19 23:47 ` Robert Love [this message]
2002-06-20 0:07 ` Andrea Arcangeli
2002-06-20 0:10 ` Robert Love
2002-06-19 23:47 ` Dave Jones
2002-06-20 17:20 ` William Lee Irwin III
2002-06-20 17:31 ` Ingo Molnar
2002-06-20 17:52 ` William Lee Irwin III
2002-06-20 18:17 ` William Lee Irwin III
2002-06-20 19:26 ` William Lee Irwin III
2002-06-21 1:34 ` William Lee Irwin III
2002-06-19 23:56 ` William Lee Irwin III
2002-06-20 7:26 ` Manik Raina
2002-06-20 13:13 ` Ingo Molnar
2002-06-20 13:34 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2002-06-20 10:11 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1024530423.917.21.camel@sinai \
--to=rml@tech9.net \
--cc=James.Bottomley@SteelEye.com \
--cc=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox