From: Robert Love <rml@tech9.net>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] fix memory leak in socket.c
Date: 15 Jul 2002 16:09:26 -0700 [thread overview]
Message-ID: <1026774566.940.496.camel@sinai> (raw)
This fixes a memory leak in sock_fasync :: net/socket.c.
I sent a fix to Linus and it is now in 2.5.
2.4 and 2.4-ac still require the fix... the following patch applies to
2.4.19-rc1 and 2.4.19-rc1-ac5.
Robert Love
diff -urN linux-2.4.19-sausage/net/socket.c linux/net/socket.c
--- linux-sausage/net/socket.c Mon Jun 10 15:26:30 2002
+++ linux/net/socket.c Mon Jun 10 15:37:48 2002
@@ -743,11 +743,13 @@
return -ENOMEM;
}
-
sock = socki_lookup(filp->f_dentry->d_inode);
- if ((sk=sock->sk) == NULL)
+ if ((sk=sock->sk) == NULL) {
+ if (fna)
+ kfree(fna);
return -EINVAL;
+ }
lock_sock(sk);
next reply other threads:[~2002-07-15 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-15 23:09 Robert Love [this message]
2002-07-16 5:27 ` [PATCH] fix memory leak in socket.c David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1026774566.940.496.camel@sinai \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox