From: Robert Love <rml@tech9.net>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: [patch] "big IRQ lock" removal, 2.5.27-A1
Date: 21 Jul 2002 12:38:54 -0700 [thread overview]
Message-ID: <1027280334.1086.1027.camel@sinai> (raw)
In-Reply-To: <Pine.LNX.4.44.0207212111300.24336-100000@localhost.localdomain>
On Sun, 2002-07-21 at 12:14, Ingo Molnar wrote:
>
> On Sun, 21 Jul 2002, Linus Torvalds wrote:
>
> > This seems to have tons of stuff which makes it compile, but which is
> > just broken. Randomly changing "cli()" to "__cli()" apparently just to
> > make it compile, with no warning that its now buggy.
>
> indeed ...
>
> fixed these, and have categorized every change whether it's safe,
> known-unsafe or unknown-effect, and commented the latter two.
Good.
I have brought up a machine with a config similar but not identical to
yours and I am putting it through the paces (SMP+preempt machine). I
really think you nailed this dead on - you did it right - we just need
to clean up the mess you left behind ;)
Ingo, looking over the FIXMEs in the tty layer I think they are
definitely _broke_. At least some of these paths have no global
synchronization now. Someone really needs to go through this cruft and
clean it up and do some proper locking.
Robert Love
next prev parent reply other threads:[~2002-07-21 19:35 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-21 18:50 [patch] "big IRQ lock" removal, 2.5.27-A1 Ingo Molnar
2002-07-21 19:00 ` Linus Torvalds
2002-07-21 19:14 ` Ingo Molnar
2002-07-21 19:24 ` Ingo Molnar
2002-07-21 20:41 ` [patch] "big IRQ lock" removal, 2.5.27-A5 Ingo Molnar
2002-07-21 20:50 ` Ingo Molnar
2002-07-21 20:59 ` [patch] "big IRQ lock" removal, 2.5.27-A7 Ingo Molnar
2002-07-21 21:26 ` [patch] "big IRQ lock" removal, 2.5.27-A9 Ingo Molnar
2002-07-21 21:46 ` Christoph Hellwig
2002-07-21 21:56 ` Ingo Molnar
2002-07-21 23:20 ` Linus Torvalds
2002-07-22 0:31 ` Ingo Molnar
2002-07-22 0:40 ` Russell King
2002-07-22 0:55 ` Robert Love
2002-07-22 13:01 ` [patch] cli()/sti() cleanup, 2.5.27-A2 Ingo Molnar
2002-07-22 13:20 ` Christoph Hellwig
2002-07-22 13:23 ` Ingo Molnar
2002-07-22 13:26 ` Christoph Hellwig
2002-07-22 13:26 ` Ingo Molnar
2002-07-22 13:30 ` Christoph Hellwig
2002-07-22 13:36 ` [patch] remove-irqlock-2.5.27-D7 Ingo Molnar
2002-07-22 13:38 ` [patch] cli()/sti() cleanup, 2.5.27-A2 Ingo Molnar
2002-07-22 13:43 ` Christoph Hellwig
2002-07-22 13:49 ` Ingo Molnar
2002-07-22 14:00 ` Marcin Dalecki
2002-07-22 14:07 ` Ingo Molnar
2002-07-22 13:24 ` Christoph Hellwig
2002-07-22 13:43 ` Ingo Molnar
2002-07-22 13:46 ` Russell King
2002-07-22 13:49 ` Ingo Molnar
2002-07-30 9:17 ` Pavel Machek
2002-07-22 13:57 ` Marcin Dalecki
2002-07-22 14:05 ` Ingo Molnar
2002-07-22 14:27 ` Russell King
2002-07-22 14:28 ` Ingo Molnar
2002-07-22 13:46 ` Christoph Hellwig
2002-07-22 13:52 ` Ingo Molnar
2002-07-22 17:13 ` Linus Torvalds
2002-07-22 18:01 ` Ingo Molnar
2002-07-23 6:48 ` Zwane Mwaikambo
2002-07-22 1:00 ` [patch] "big IRQ lock" removal, 2.5.27-A9 Robert Love
2002-07-21 23:43 ` Russell King
2002-07-21 23:44 ` Ingo Molnar
2002-07-21 23:47 ` Russell King
2002-07-21 23:58 ` Ingo Molnar
2002-07-22 1:04 ` Alan Cox
2002-07-21 23:52 ` Ingo Molnar
2002-07-21 22:17 ` [patch] "big IRQ lock" removal, 2.5.27-A5 Alan Cox
2002-07-21 19:38 ` Robert Love [this message]
2002-07-21 22:19 ` [patch] "big IRQ lock" removal, 2.5.27-A1 Ingo Molnar
2002-07-21 23:55 ` Robert Love
2002-07-21 19:58 ` Russell King
2002-07-21 20:09 ` Ingo Molnar
2002-07-21 20:42 ` Russell King
2002-07-21 21:09 ` Ingo Molnar
2002-07-21 21:18 ` Russell King
2002-07-21 21:20 ` Ingo Molnar
2002-07-21 21:29 ` Ingo Molnar
2002-07-21 21:39 ` Ingo Molnar
2002-07-21 23:23 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1027280334.1086.1027.camel@sinai \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox