From: Robert Love <rml@tech9.net>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@transmeta.com>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] "big IRQ lock" removal, 2.5.27-A9
Date: 21 Jul 2002 17:55:26 -0700 [thread overview]
Message-ID: <1027299327.931.3.camel@sinai> (raw)
In-Reply-To: <20020722014018.A31813@flint.arm.linux.org.uk>
On Sun, 2002-07-21 at 17:40, Russell King wrote:
> On Mon, Jul 22, 2002 at 02:31:16AM +0200, Ingo Molnar wrote:
> > +drivers that want to disable local interrupts (interrupts on the
> > +current CPU), can use the following four macros:
> > +
> > + __cli(), __sti(), __save_flags(flags), __restore_flags(flags)
>
> Last mail before zzz (hopefully) - what about
> local_irq_{enable,disable,save,restore} ?
>
> With the exception of local_irq_save() which is actually
> local_irq_save_disable(), I find these to be more "descriptive" of
> their function.
Yes and double yes.
And for two reasons: First, the __ prefix is unnecessary now. Second,
not all the world is an x86 (it just looks that way).
local_irq_foo is definitely preferred.
I'd make the patch and go through the effort to rename and replace if
Linus assured me it was in.
Robert Love
next prev parent reply other threads:[~2002-07-22 0:52 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-21 18:50 [patch] "big IRQ lock" removal, 2.5.27-A1 Ingo Molnar
2002-07-21 19:00 ` Linus Torvalds
2002-07-21 19:14 ` Ingo Molnar
2002-07-21 19:24 ` Ingo Molnar
2002-07-21 20:41 ` [patch] "big IRQ lock" removal, 2.5.27-A5 Ingo Molnar
2002-07-21 20:50 ` Ingo Molnar
2002-07-21 20:59 ` [patch] "big IRQ lock" removal, 2.5.27-A7 Ingo Molnar
2002-07-21 21:26 ` [patch] "big IRQ lock" removal, 2.5.27-A9 Ingo Molnar
2002-07-21 21:46 ` Christoph Hellwig
2002-07-21 21:56 ` Ingo Molnar
2002-07-21 23:20 ` Linus Torvalds
2002-07-22 0:31 ` Ingo Molnar
2002-07-22 0:40 ` Russell King
2002-07-22 0:55 ` Robert Love [this message]
2002-07-22 13:01 ` [patch] cli()/sti() cleanup, 2.5.27-A2 Ingo Molnar
2002-07-22 13:20 ` Christoph Hellwig
2002-07-22 13:23 ` Ingo Molnar
2002-07-22 13:26 ` Christoph Hellwig
2002-07-22 13:26 ` Ingo Molnar
2002-07-22 13:30 ` Christoph Hellwig
2002-07-22 13:36 ` [patch] remove-irqlock-2.5.27-D7 Ingo Molnar
2002-07-22 13:38 ` [patch] cli()/sti() cleanup, 2.5.27-A2 Ingo Molnar
2002-07-22 13:43 ` Christoph Hellwig
2002-07-22 13:49 ` Ingo Molnar
2002-07-22 14:00 ` Marcin Dalecki
2002-07-22 14:07 ` Ingo Molnar
2002-07-22 13:24 ` Christoph Hellwig
2002-07-22 13:43 ` Ingo Molnar
2002-07-22 13:46 ` Russell King
2002-07-22 13:49 ` Ingo Molnar
2002-07-30 9:17 ` Pavel Machek
2002-07-22 13:57 ` Marcin Dalecki
2002-07-22 14:05 ` Ingo Molnar
2002-07-22 14:27 ` Russell King
2002-07-22 14:28 ` Ingo Molnar
2002-07-22 13:46 ` Christoph Hellwig
2002-07-22 13:52 ` Ingo Molnar
2002-07-22 17:13 ` Linus Torvalds
2002-07-22 18:01 ` Ingo Molnar
2002-07-23 6:48 ` Zwane Mwaikambo
2002-07-22 1:00 ` [patch] "big IRQ lock" removal, 2.5.27-A9 Robert Love
2002-07-21 23:43 ` Russell King
2002-07-21 23:44 ` Ingo Molnar
2002-07-21 23:47 ` Russell King
2002-07-21 23:58 ` Ingo Molnar
2002-07-22 1:04 ` Alan Cox
2002-07-21 23:52 ` Ingo Molnar
2002-07-21 22:17 ` [patch] "big IRQ lock" removal, 2.5.27-A5 Alan Cox
2002-07-21 19:38 ` [patch] "big IRQ lock" removal, 2.5.27-A1 Robert Love
2002-07-21 22:19 ` Ingo Molnar
2002-07-21 23:55 ` Robert Love
2002-07-21 19:58 ` Russell King
2002-07-21 20:09 ` Ingo Molnar
2002-07-21 20:42 ` Russell King
2002-07-21 21:09 ` Ingo Molnar
2002-07-21 21:18 ` Russell King
2002-07-21 21:20 ` Ingo Molnar
2002-07-21 21:29 ` Ingo Molnar
2002-07-21 21:39 ` Ingo Molnar
2002-07-21 23:23 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1027299327.931.3.camel@sinai \
--to=rml@tech9.net \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox