From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: fix for pci_enable_device in 2.4.19ac3
Date: 04 Aug 2002 22:32:13 -0700 [thread overview]
Message-ID: <1028525533.1922.5.camel@ixodes.goop.org> (raw)
I found my tulip driver was complaining about not being able to enable
the device. Turns out this was the problem:
==== //depot/linux/2.4ac/drivers/pci/pci.c#3 - /home/jeremy/p4/linux/2.4ac/drivers/pci/pci.c ====
@@ -389,7 +389,7 @@
int
pci_enable_device(struct pci_dev *dev)
{
- pci_enable_device_bars(dev, 0x3F);
+ return pci_enable_device_bars(dev, 0x3F);
}
/**
I guess nobody else checks their error returns (or it just happened to
always return 0).
J
[ sorry about the resend; forgot to turn off HTML ]
reply other threads:[~2002-08-05 5:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1028525533.1922.5.camel@ixodes.goop.org \
--to=jeremy@goop.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox