From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S267316AbUGNILg@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S267316AbUGNILg (ORCPT <rfc822;willy@w.ods.org>);
	Wed, 14 Jul 2004 04:11:36 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267318AbUGNILg
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 14 Jul 2004 04:11:36 -0400
Received: from mx1.redhat.com ([66.187.233.31]:42423 "EHLO mx1.redhat.com")
	by vger.kernel.org with ESMTP id S267316AbUGNILf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 Jul 2004 04:11:35 -0400
From: David Howells <dhowells@redhat.com>
In-Reply-To: <20040714002912.26ed0e66.akpm@osdl.org> 
References: <20040714002912.26ed0e66.akpm@osdl.org>  <20040713182559.7534e46d.akpm@osdl.org> 
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, "Jose R. Santos" <jrsantos@austin.ibm.com>
Subject: Re: 2.6.8-rc1-mm1 
User-Agent: EMH/1.14.1 SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386-redhat-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
Date: Wed, 14 Jul 2004 09:11:29 +0100
Message-ID: <10289.1089792689@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org


> btw, David, I'm wondering about this loop:
> 
> 	do {
> 		size = bucketsize << log2qty;
> 
> 		table = (void *) alloc_bootmem(size);
> 
> 	} while (!table && size > PAGE_SIZE);
> 
> Is this a busy-wait-until-someone-plugs-in-more-ram-chips thing? ;)

Well, with IBM hardware, you never know:-)

Yeah... that got fixed here in my 2.4 version, and I failed to transfer the
fix across. log2qty should be decremented every time around the loop:

-	} while (!table && size > PAGE_SIZE);
+	} while (!table && size > PAGE_SIZE && --log2qty);

David