Re: [PATCH] (re-xmit): kprobes for i386

Luca Barbieri
2002-08-21T01:25:43Z

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

> > > + if (kprobe_running() && kprobe_fault_handler(regs, trapnr))
> > > + return;
> > > if (!(regs->xcs & 3))
> > > goto kernel_trap;
> > The kprobe check should be after the kernel_trap label.
>
> No. The entire *point* of being able to register a kprobe fault
> handler is to be able to handle any kernel faults yourself if you want
> to.
It seems you have misunderstood my point.
My idea is that since kprobes are only used for kernel mode address, we
should move the kprobe check in the code that executes after we check
that the fault is happening in kernel mode.

Soemthing like this:
if (!(regs->xcs & 3))
goto kernel_trap;

[...]

kernel_trap:
if (kprobe_running() && kprobe_fault_handler(regs, trapnr))
return;

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]