From: Robert Love <rml@tech9.net>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] make raid5 checksums preempt-safe
Date: 26 Aug 2002 16:06:03 -0400 [thread overview]
Message-ID: <1030392363.905.418.camel@phantasy> (raw)
Linus,
The raid5 xor checksums use MMX/SSE state and are not preempt-safe.
Attached patch disables preemption in FPU_SAVE and XMMS_SAVE and
restores it in FPU_RESTORE and XMMS_RESTORE - preventing preemption
while in fp mode.
Please, apply.
Robert Love
diff -urN linux-2.5.31/include/asm-i386/xor.h linux/include/asm-i386/xor.h
--- linux-2.5.31/include/asm-i386/xor.h Sat Aug 10 21:41:20 2002
+++ linux/include/asm-i386/xor.h Sat Aug 24 20:14:43 2002
@@ -20,6 +20,7 @@
#define FPU_SAVE \
do { \
+ preempt_disable(); \
if (!test_thread_flag(TIF_USEDFPU)) \
__asm__ __volatile__ (" clts;\n"); \
__asm__ __volatile__ ("fsave %0; fwait": "=m"(fpu_save[0])); \
@@ -30,6 +31,7 @@
__asm__ __volatile__ ("frstor %0": : "m"(fpu_save[0])); \
if (!test_thread_flag(TIF_USEDFPU)) \
stts(); \
+ preempt_enable(); \
} while (0)
#define LD(x,y) " movq 8*("#x")(%1), %%mm"#y" ;\n"
@@ -543,6 +545,7 @@
*/
#define XMMS_SAVE \
+ preempt_disable(); \
__asm__ __volatile__ ( \
"movl %%cr0,%0 ;\n\t" \
"clts ;\n\t" \
@@ -564,7 +567,8 @@
"movl %0,%%cr0 ;\n\t" \
: \
: "r" (cr0), "r" (xmm_save) \
- : "memory")
+ : "memory") \
+ preempt_enable();
#define ALIGN16 __attribute__((aligned(16)))
diff -urN linux-2.5.31/include/asm-x86_64/xor.h linux/include/asm-x86_64/xor.h
--- linux-2.5.31/include/asm-x86_64/xor.h Sat Aug 10 21:41:23 2002
+++ linux/include/asm-x86_64/xor.h Sat Aug 24 20:05:41 2002
@@ -38,7 +38,8 @@
/* Doesn't use gcc to save the XMM registers, because there is no easy way to
tell it to do a clts before the register saving. */
#define XMMS_SAVE \
- asm volatile ( \
+ preempt_disable(); \
+ asm volatile ( \
"movq %%cr0,%0 ;\n\t" \
"clts ;\n\t" \
"movups %%xmm0,(%1) ;\n\t" \
@@ -59,7 +60,8 @@
"movq %0,%%cr0 ;\n\t" \
: \
: "r" (cr0), "r" (xmm_save) \
- : "memory")
+ : "memory") \
+ preempt_enable();
#define OFFS(x) "16*("#x")"
#define PF_OFFS(x) "256+16*("#x")"
next reply other threads:[~2002-08-26 20:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-26 20:06 Robert Love [this message]
2002-08-26 21:09 ` [PATCH] make raid5 checksums preempt-safe Thunder from the hill
2002-08-26 21:15 ` Robert Love
2002-08-27 1:38 ` Horst von Brand
2002-08-27 15:25 ` Thunder from the hill
2002-08-27 15:34 ` How can a process easily get a list of all it's open fd? Mark Atwood
2002-08-27 16:08 ` Alex Riesen
2002-08-27 21:26 ` Mike Touloumtzis
2002-08-28 8:28 ` Alex Riesen
2002-08-27 23:21 ` DervishD
2002-08-26 22:33 ` [PATCH] make raid5 checksums preempt-safe Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030392363.905.418.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox