From: Luca Barbieri <ldb@ldb.ods.org>
To: "David S. Miller" <davem@redhat.com>
Cc: s.biggs@softier.com, Linux-Kernel ML <linux-kernel@vger.kernel.org>
Subject: Re: Bug in kernel code?
Date: 28 Aug 2002 06:29:59 +0200 [thread overview]
Message-ID: <1030508999.1547.45.camel@ldb> (raw)
In-Reply-To: <20020827.210748.10907440.davem@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
On Wed, 2002-08-28 at 06:07, David S. Miller wrote:
> From: Luca Barbieri <ldb@ldb.ods.org>
> Date: 28 Aug 2002 06:10:39 +0200
>
> I'm not saying that it's serious bug, just that using __ffs is more
> appropriate than reimplementing it incorrectly and inefficiently.
>
> ffs won't find the smallest power of 2 >= some_arbitrary_value.
> That is what this code is doing.
Yes you are right, fls should be used there, not ffs.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2002-08-28 4:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3D6BB5C3.16057.2E515C@localhost>
[not found] ` <20020827.172304.22017977.davem@redhat.com>
2002-08-28 0:32 ` Bug in kernel code? Stephen C. Biggs
2002-08-28 0:29 ` David S. Miller
2002-08-28 0:40 ` Stephen C. Biggs
2002-08-28 0:42 ` David S. Miller
2002-08-28 1:09 ` Stephen C. Biggs
2002-08-28 1:09 ` David S. Miller
2002-08-28 1:24 ` Stephen C. Biggs
2002-08-28 1:23 ` David S. Miller
2002-08-28 2:42 ` Stephen C. Biggs
2002-08-28 3:39 ` David S. Miller
2002-08-28 3:57 ` Luca Barbieri
2002-08-28 3:58 ` David S. Miller
2002-08-28 4:10 ` Luca Barbieri
2002-08-28 4:07 ` David S. Miller
2002-08-28 4:29 ` Luca Barbieri [this message]
2002-08-28 4:29 ` Stephen Biggs
2002-08-28 4:26 ` David S. Miller
2002-08-28 21:54 ` H. Peter Anvin
2002-08-28 2:49 ` Re[2]: " Stephen C. Biggs
2002-08-28 0:54 ` Stephen C. Biggs
2002-08-28 0:25 Stephen C. Biggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030508999.1547.45.camel@ldb \
--to=ldb@ldb.ods.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.biggs@softier.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox