From: Ray Lee <ray-lk@madrabbit.org>
To: ldb@ldb.ods.org, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Re: 2.5.33 PNPBIOS does not compile
Date: 01 Sep 2002 13:17:34 -0700 [thread overview]
Message-ID: <1030911455.4803.3.camel@orca> (raw)
Hi there,
> #define Q_SET_SEL(cpu, selname, address, size) \
> set_base(cpu_gdt_table[cpu][(selname) >> 3], __va((u32)(address))); \
> -set_limit(&cpu_gdt_table[cpu][(selname) >> 3], size)
> +set_limit(cpu_gdt_table[cpu][(selname) >> 3], size)
> #define Q2_SET_SEL(cpu, selname, address, size) \
> set_base(cpu_gdt_table[cpu][(selname) >> 3], (u32)(address)); \
> -set_limit(&cpu_gdt_table[cpu][(selname) >> 3], size)
> +set_limit(cpu_gdt_table[cpu][(selname) >> 3], size)
These look very wrong. They're not wrapped in the standard do {...}
while(0) protection, and used inside bare if statements below. Can
someone who knows the code verify that these should be wrapped?
(Not, mind you, that I'm complaining about your patch. You didn't
introduce the problem, it just caught my eye.)
Ray
next reply other threads:[~2002-09-01 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-01 20:17 Ray Lee [this message]
2002-09-01 21:35 ` [PATCH] Re: 2.5.33 PNPBIOS does not compile Ray Lee
-- strict thread matches above, loose matches on Subject: below --
2002-09-01 7:14 Nicholas Miell
2002-09-01 19:18 ` [PATCH] " Luca Barbieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030911455.4803.3.camel@orca \
--to=ray-lk@madrabbit.org \
--cc=ldb@ldb.ods.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox