Re: [PATCH] BUG(): sched.c: Line 944

Robert Love
2002-09-16T22:10:54Z

On Mon, 2002-09-16 at 17:41, Linus Torvalds wrote:

> Ok. Let's just make the masking explicit in in_atomic() then, like you
> suggest:

OK.

But, ugh, more fun: we preempt_disable() in do_exit(). Every exiting
task hits the test. My syslog is huge.

At least for now, can we please revert the check to in_interrupt() ?

Robert Love

diff -urN linux-2.5.35/kernel/sched.c linux/kernel/sched.c
--- linux-2.5.35/kernel/sched.c Sun Sep 15 22:18:24 2002
+++ linux/kernel/sched.c Mon Sep 16 18:17:06 2002
@@ -940,7 +940,7 @@
struct list_head *queue;
int idx;

- if (unlikely(in_atomic()))
+ if (unlikely(in_interrupt()))
BUG();

#if CONFIG_DEBUG_HIGHMEM