From: Robert Love <rml@tech9.net>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] BUG(): sched.c: Line 944
Date: 16 Sep 2002 19:15:09 -0400 [thread overview]
Message-ID: <1032218110.1203.63.camel@phantasy> (raw)
In-Reply-To: <Pine.LNX.4.44.0209161524500.1451-100000@home.transmeta.com>
On Mon, 2002-09-16 at 18:26, Linus Torvalds wrote:
> On 16 Sep 2002, Robert Love wrote:
> >
> > At least for now, can we please revert the check to in_interrupt() ?
>
> I really think the test is correct, and if we revert it now, we certainly
> won't be able to re-introduce it later when we're closer to 2.6.
>
> So if the in_atomic() change is enough to fix everything but do_exit(),
> then how about just making do_exit() use PREEMPT_ACTIVE instead?
Nope. If PREEMPT_ACTIVE is set, schedule() assumes the task is being
preempted and skips certain logic e.g. deactivate_task() (this is the
same code that lets us safely preempt a TASK_ZOMBIE).
Result is death before init even executes.
Ugh...
Robert Love
next prev parent reply other threads:[~2002-09-16 23:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-16 18:48 [PATCH] BUG(): sched.c: Line 944 Robert Love
2002-09-16 19:01 ` Linus Torvalds
2002-09-16 21:14 ` Robert Love
2002-09-16 21:41 ` Linus Torvalds
2002-09-16 22:15 ` Robert Love
2002-09-16 22:26 ` Linus Torvalds
2002-09-16 23:15 ` Robert Love [this message]
2002-09-16 23:45 ` Linus Torvalds
2002-09-16 23:58 ` Robert Love
2002-09-17 5:56 ` Linus Torvalds
2002-09-17 8:12 ` Robert Love
2002-09-17 8:51 ` Robert Love
2002-09-17 8:59 ` Robert Love
2002-09-17 9:57 ` Ingo Molnar
2002-09-17 18:27 ` Robert Love
2002-09-17 18:46 ` Ingo Molnar
2002-09-17 14:10 ` Steven Cole
2002-09-17 18:29 ` Robert Love
2002-09-17 18:42 ` Steven Cole
2002-09-17 15:27 ` Linus Torvalds
2002-09-17 15:40 ` Linus Torvalds
2002-09-17 15:53 ` Ingo Molnar
2002-09-17 16:18 ` Linus Torvalds
2002-09-17 16:26 ` Ingo Molnar
2002-09-17 18:47 ` Robert Love
2002-09-17 18:57 ` Ingo Molnar
2002-09-17 19:23 ` Robert Love
2002-09-17 19:54 ` Steven Cole
2002-09-17 20:06 ` Robert Love
2002-09-17 20:32 ` Steven Cole
2002-09-17 20:58 ` Steven Cole
2002-09-18 4:44 ` Robert Love
2002-09-18 14:08 ` Steven Cole
2002-09-17 15:54 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1032218110.1203.63.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox