From: Robert Love <rml@tech9.net>
To: mingo@elte.hu
Cc: linux-kernel@vger.kernel.org
Subject: non-atomic test victim #1
Date: 17 Sep 2002 16:33:33 -0400 [thread overview]
Message-ID: <1032294813.4592.241.camel@phantasy> (raw)
Current kernel with the non-atomic test I sent, SMP with preemption.
I only get two triggers, both during boot. They are on migration_thread
and ksoftirqd startup. The problem lies in set_cpus_allowed():
Trace; c0116ac4 <schedule+a4/4b0>
Trace; c011731a <wait_for_completion+11a/1d0>
Trace; c0116f30 <default_wake_function+0/40>
Trace; c0115d02 <try_to_wake_up+312/320>
Trace; c0116f30 <default_wake_function+0/40>
Trace; c0118f0f <set_cpus_allowed+22f/250>
Trace; c0118f7d <migration_thread+4d/590>
Trace; c0118f30 <migration_thread+0/590>
Trace; c0118f30 <migration_thread+0/590>
Trace; c010586d <kernel_thread_helper+5/18>
It is obviously the preempt_disable() which we hold past the wake_up().
The issue is that, without this preempt_disable() there have been
observed crashes, especially on large n-way machines. Both Andrew
Morton and Anton Blanchard have reported the problem and that this fixes
it.
Question is, why does set_cpus_allowed() need it? I do not see it... it
must be an issue with an early preemption and the resulting
migration_thread?
Ingo, ideas?
Robert Love
reply other threads:[~2002-09-17 20:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1032294813.4592.241.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox