From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org,
Jerome Oufella <jerome.oufella@savoirfairelinux.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2] gpio: add TS-5500 DIO blocks support
Date: Wed, 19 Dec 2012 17:13:47 -0500 (EST) [thread overview]
Message-ID: <1032450702.626703.1355955227194.JavaMail.root@mail.savoirfairelinux.com> (raw)
In-Reply-To: <20121219171600.7B0EF3E0C5A@localhost>
Hi Grant,
> Please take a look at either send me a follow-on patch to convert it
> to use gpio-generic, or tell my why gpio-generic isn't appropriate here.
The gpio-generic driver is not appropriate here because Technologic Systems
x86-based platforms do not use a typical GPIO implementation.
To name a few specificities:
- The GPIOs are available through ioport and not iomem
- There are input-only/output-only/input-output lines on the same block
- The number of GPIOs differs between blocks (currently 11, 13 and 14 pins)
- A single bit in a control register drives the direction of 4 input/output
lines, while the register's other bits have different functions.
IMHO these considerations justify a specific GPIO driver to support these
Technologic Systems pin blocks.
Regards,
Vivien
prev parent reply other threads:[~2012-12-19 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 2:36 [PATCH v2] gpio: add TS-5500 DIO blocks support Vivien Didelot
2012-12-10 9:55 ` Linus Walleij
2012-12-19 17:16 ` Grant Likely
2012-12-19 22:13 ` Vivien Didelot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1032450702.626703.1355955227194.JavaMail.root@mail.savoirfairelinux.com \
--to=vivien.didelot@savoirfairelinux.com \
--cc=grant.likely@secretlab.ca \
--cc=jerome.oufella@savoirfairelinux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).