From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754016AbbKCNwE (ORCPT ); Tue, 3 Nov 2015 08:52:04 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:55941 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbbKCNwB (ORCPT ); Tue, 3 Nov 2015 08:52:01 -0500 From: Arnd Bergmann To: Michael Grzeschik , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] arcnet/com20020: add LEDS_CLASS dependency Date: Tue, 03 Nov 2015 14:51:29 +0100 Message-ID: <10338405.rWTFsWuIBE@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:G8AyYJWJ3lqzU46FQX2gRbKd4/85q/RUlmQUob2g+RTCf5bm5x5 aAo90vAP5ergwalVshM0ZSyxiawzTEbAI081afOGibnWMrdoD+dOMy7jr4CX405ZH+dj53u v6RzXhSxmzvLM4Lkbq1wTaDusd+fW/yk57YsNasnrJA5qRwVCeonin9drRXx/i38pLWlCEt asViqkZbaW1XKU+e9H3/A== X-UI-Out-Filterresults: notjunk:1;V01:K0:3B2tboe5Mls=:tXupW7D+R2v8YGc80Pyuta NCIkKaIOmct1KqhIIjo0BGHySe7EIBfYE2Lyb6XcSqsy8kiKY3QHsYAAjQXy7ax0CZOOzl83g UcntHAFbXI3p2nGV/64p5c9EyYqqc2qLOu4bJTR/58kmw4Jd+7P990pbzxVEsZqkyx6goAUFy +jyeFciSfeB5ex7RJhZ988MHND5TJYeFCHe2hVROxYx73+HQYlEh30lpvdqKrVH3vDqRNok55 S/npSy78pgJ1y2klyuNiYy0+b4JOnvYz66R4YDeD67ovbFbH/d2sx6+ryftsSqLdlkbTfBVMD EZOieMsR1ENzT/K4wFBGo7uQN8ma+mEodkdvz7td/AaJDPF+RUDtuNt1GkzPbPtDN8YdFmDDF 790bcVvFX7MPU4xSTE/5WRhJQOYHoG4zPcCjTzy9gm6w1lVVNkDe9a7KzE0gHRHeY/vQSYfKQ yjw4kGmnZiBTb/gkudpg5gBatjZAPWGhO205EFwvn8VNB+PGDqsLR46tSM1EnOKXY3efE1Q7D Cd7FhzxmsikpKunO3l118kXpdYqdi+VD5EH8gjlPlInl+tPa2qmbEDaJW5Wv02oY/JRCx8+H1 TQUWtG1PRaBDjxoYLyFl9/XCKfv9kpghWL7QsUkQruzQuncg1G71RmRWcfOCRC1hvs1lSu8FZ kpmfpNPOLW6+baZDOADrx2mkErW/GqT84OyDwb7fUuaZuZ0hgfdYGN6H8xisldlA9YJSnFrha 2/H97IGuypfkqTBY Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added led trigger support in the com20020-pci driver causes build errors when CONFIG_LEDS_CLASS is disabled: drivers/built-in.o: In function `com20020pci_probe': (.text+0x185dc4): undefined reference to `devm_led_classdev_register' (.text+0x185dd8): undefined reference to `devm_led_classdev_register' This adds a Kconfig dependency to prevent the invalid configurations. Other drivers appear to be split 50:50 between 'select' and 'depends on' for this symbol, I picked 'depends on' as I could not find a common policy and it generally causes fewer problems. Signed-off-by: Arnd Bergmann Fixes: 8890624a4e8c ("arcnet: com20020-pci: add led trigger support") --- Found on ARM randconfig build tests diff --git a/drivers/net/arcnet/Kconfig b/drivers/net/arcnet/Kconfig index 2a9c3c3abe9b..39bd16f3f86d 100644 --- a/drivers/net/arcnet/Kconfig +++ b/drivers/net/arcnet/Kconfig @@ -103,6 +103,7 @@ config ARCNET_RIM_I config ARCNET_COM20020 tristate "ARCnet COM20020 chipset driver" + depends on LEDS_CLASS help This is the driver for the new COM20020 chipset. It supports such things as promiscuous mode, so packet sniffing is possible, and