From: Robert Love <rml@tech9.net>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] getpid() comment typo
Date: 07 Oct 2002 21:53:42 -0400 [thread overview]
Message-ID: <1034042022.29467.282.camel@phantasy> (raw)
Linus,
Comment above getpid() is wrong.
This patch fixes it, and expands the comment to explain why on earth we
have getpid() returning ->tgid and not ->pid.
Patch is against 2.5.41, por favor, mi mejor pingüino, se aplica.
Robert Love
diff -urN linux-2.5.41/kernel/timer.c linux/kernel/timer.c
--- linux-2.5.41/kernel/timer.c 2002-10-07 14:24:00.000000000 -0400
+++ linux/kernel/timer.c 2002-10-07 21:37:28.000000000 -0400
@@ -798,10 +798,18 @@
* The Alpha uses getxpid, getxuid, and getxgid instead. Maybe this
* should be moved into arch/i386 instead?
*/
-
+
+/**
+ * sys_getpid - return the thread group id of the current process
+ *
+ * Note, despite the name, this returns the tgid not the pid. The tgid and
+ * the pid are identical unless CLONE_THREAD was specified on clone() in
+ * which case the tgid is the same in all threads of the same group.
+ *
+ * This is SMP safe as current->tgid does not change.
+ */
asmlinkage long sys_getpid(void)
{
- /* This is SMP safe - current->pid doesn't change */
return current->tgid;
}
reply other threads:[~2002-10-08 1:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1034042022.29467.282.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox