public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: Linus Torvalds <torvalds@transmeta.com>, greg kh <greg@kroah.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] linux-2.5.41_cyclone-fixes_A0
Date: 10 Oct 2002 18:09:39 -0700	[thread overview]
Message-ID: <1034298580.19094.53.camel@cog> (raw)

Linus, 
	This patch just syncs up the cyclone-timer code w/ Greg's changes from
this morning. 

Please apply.

thanks
-john


diff -Nru a/arch/i386/kernel/timers/timer_cyclone.c b/arch/i386/kernel/timers/timer_cyclone.c
--- a/arch/i386/kernel/timers/timer_cyclone.c	Thu Oct 10 18:07:14 2002
+++ b/arch/i386/kernel/timers/timer_cyclone.c	Thu Oct 10 18:07:14 2002
@@ -81,7 +81,7 @@
 	
 	/*make sure we're on a summit box*/
 	/*XXX need to use proper summit hooks! such as xapic -john*/
-	if(!use_cyclone) return 0; 
+	if(!use_cyclone) return -ENODEV; 
 	
 	printk(KERN_INFO "Summit chipset: Starting Cyclone Counter.\n");
 
@@ -92,12 +92,12 @@
 	reg = (u32*)(fix_to_virt(FIX_CYCLONE_TIMER) + offset);
 	if(!reg){
 		printk(KERN_ERR "Summit chipset: Could not find valid CBAR register.\n");
-		return 0;
+		return -ENODEV;
 	}
 	base = *reg;	
 	if(!base){
 		printk(KERN_ERR "Summit chipset: Could not find valid CBAR value.\n");
-		return 0;
+		return -ENODEV;
 	}
 	
 	/* setup PMCC */
@@ -107,7 +107,7 @@
 	reg = (u32*)(fix_to_virt(FIX_CYCLONE_TIMER) + offset);
 	if(!reg){
 		printk(KERN_ERR "Summit chipset: Could not find valid PMCC register.\n");
-		return 0;
+		return -ENODEV;
 	}
 	reg[0] = 0x00000001;
 
@@ -118,7 +118,7 @@
 	reg = (u32*)(fix_to_virt(FIX_CYCLONE_TIMER) + offset);
 	if(!reg){
 		printk(KERN_ERR "Summit chipset: Could not find valid MPCS register.\n");
-		return 0;
+		return -ENODEV;
 	}
 	reg[0] = 0x00000001;
 
@@ -129,7 +129,7 @@
 	cyclone_timer = (u32*)(fix_to_virt(FIX_CYCLONE_TIMER) + offset);
 	if(!cyclone_timer){
 		printk(KERN_ERR "Summit chipset: Could not find valid MPMC register.\n");
-		return 0;
+		return -ENODEV;
 	}
 
 	/*quick test to make sure its ticking*/
@@ -140,12 +140,12 @@
 		if(cyclone_timer[0] == old){
 			printk(KERN_ERR "Summit chipset: Counter not counting! DISABLED\n");
 			cyclone_timer = 0;
-			return 0;
+			return -ENODEV;
 		}
 	}
 
 	/* Everything looks good! */
-	return 1;
+	return 0;
 }
 





             reply	other threads:[~2002-10-11  1:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-11  1:09 john stultz [this message]
2002-10-11  1:32 ` [whoops][PATCH] linux-2.5.41_cyclone-fixes_A1 john stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1034298580.19094.53.camel@cog \
    --to=johnstul@us.ibm.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox