public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Love <rml@tech9.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jakub Jelinek <jakub@redhat.com>,
	Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Dave Jones <davej@suse.de>
Subject: Re: Some functions are not inlined by gcc 3.2, resulting code is ugly
Date: 03 Nov 2002 20:21:32 -0500	[thread overview]
Message-ID: <1036372893.752.11.camel@phantasy> (raw)
In-Reply-To: <1036340502.29642.36.camel@irongate.swansea.linux.org.uk>

On Sun, 2002-11-03 at 11:21, Alan Cox wrote:

> I would venture the reverse interpretation for modern processors,
> the kernel inlines far far too much

I agree 100% we mark too much as inline - but at the same time, some
larger functions are inline simply because they were originally part of
another function and pulled out for cleanliness.  They are only used
once...  in other words, in some cases I hope the kernel developers know
what they are doing when they mark stuff inline.

So I can see why bumping this limit very high is a good thing.  At the
same time, there is a lot of stuff incorrectly inlined and we should go
through and un-inline all of that, too.

	Robert Love


  parent reply	other threads:[~2002-11-04  1:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-03 16:17 Some functions are not inlined by gcc 3.2, resulting code is ugly Denis Vlasenko
2002-11-03 16:17 ` Jussi Laako
2002-11-04  0:17   ` Denis Vlasenko
2002-11-03 21:28     ` Jussi Laako
2002-11-04 16:00       ` Denis Vlasenko
2002-11-03 18:14 ` Denis Vlasenko
2002-11-03 15:23   ` Martin J. Bligh
2002-11-04  0:23     ` Denis Vlasenko
2002-11-03 15:37   ` Jakub Jelinek
2002-11-03 16:21     ` Alan Cox
2002-11-04  0:20       ` Denis Vlasenko
2002-11-03 20:28         ` Alan Cox
2002-11-04 16:08           ` Denis Vlasenko
2002-11-13  1:28         ` J.A. Magallón
2002-11-13 11:54           ` Denis Vlasenko
2002-11-13 12:48             ` Denis Vlasenko
2002-11-04  1:21       ` Robert Love [this message]
2002-11-04 13:41         ` Alan Cox
2002-11-04 22:44           ` Werner Almesberger
2002-11-04 16:04         ` Denis Vlasenko
2002-11-04 11:39           ` Jakub Jelinek
2002-11-13  0:10   ` J.A. Magallón
2002-11-13 12:04     ` Denis Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1036372893.752.11.camel@phantasy \
    --to=rml@tech9.net \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davej@suse.de \
    --cc=jakub@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vda@port.imtp.ilyichevsk.odessa.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox