From: Larry Chiu <larry.chiu@realtek.com>
To: Paolo Abeni <pabeni@redhat.com>,
Justin Lai <justinlai0215@realtek.com>,
"kuba@kernel.org" <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"horms@kernel.org" <horms@kernel.org>,
"rkannoth@marvell.com" <rkannoth@marvell.com>,
"jdamato@fastly.com" <jdamato@fastly.com>,
Ping-Ke Shih <pkshih@realtek.com>
Subject: RE: [PATCH net-next v28 07/13] rtase: Implement a function to receive packets
Date: Tue, 27 Aug 2024 10:46:43 +0000 [thread overview]
Message-ID: <1036b59d9aa541db9b59a0cdc5868d9c@realtek.com> (raw)
In-Reply-To: <c38c1482-1574-4cc9-9ebf-aa5ad30d627a@redhat.com>
> > +
> > + skb = build_skb(ring->data_buf[entry], PAGE_SIZE);
> > + if (!skb) {
> > + netdev_err(dev, "skb build failed\n");
>
> I'm sorry for this late feedback, but the above message should be
> dropped, too.
>
> As pointed out by Jakub in the previous revision, this allocation can
> fail, and the counter increase below will give exactly the same amount
> of information, without potentially filling the dmseg buffer.
>
> FWIW, I think the above is the last item pending.
>
> Thanks,
>
> Paolo
Thank you for taking the time to review.
We will remove it in the next version.
Larry
next prev parent reply other threads:[~2024-08-27 10:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 9:37 [PATCH net-next v28 00/13] Add Realtek automotive PCIe driver Justin Lai
2024-08-22 9:37 ` [PATCH net-next v28 01/13] rtase: Add support for a pci table in this module Justin Lai
2024-08-22 9:37 ` [PATCH net-next v28 02/13] rtase: Implement the .ndo_open function Justin Lai
2024-08-22 9:37 ` [PATCH net-next v28 03/13] rtase: Implement the rtase_down function Justin Lai
2024-08-22 9:37 ` [PATCH net-next v28 04/13] rtase: Implement the interrupt routine and rtase_poll Justin Lai
2024-08-22 9:37 ` [PATCH net-next v28 05/13] rtase: Implement hardware configuration function Justin Lai
2024-08-22 9:37 ` [PATCH net-next v28 06/13] rtase: Implement .ndo_start_xmit function Justin Lai
2024-08-22 9:37 ` [PATCH net-next v28 07/13] rtase: Implement a function to receive packets Justin Lai
2024-08-27 9:53 ` Paolo Abeni
2024-08-27 10:46 ` Larry Chiu [this message]
2024-08-22 9:37 ` [PATCH net-next v28 08/13] rtase: Implement net_device_ops Justin Lai
2024-08-22 9:37 ` [PATCH net-next v28 09/13] rtase: Implement pci_driver suspend and resume function Justin Lai
2024-08-22 9:37 ` [PATCH net-next v28 10/13] rtase: Implement ethtool function Justin Lai
2024-08-22 9:37 ` [PATCH net-next v28 11/13] rtase: Add a Makefile in the rtase folder Justin Lai
2024-08-22 9:37 ` [PATCH net-next v28 12/13] realtek: Update the Makefile and Kconfig in the realtek folder Justin Lai
2024-08-22 9:37 ` [PATCH net-next v28 13/13] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1036b59d9aa541db9b59a0cdc5868d9c@realtek.com \
--to=larry.chiu@realtek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=jiri@resnulli.us \
--cc=justinlai0215@realtek.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
--cc=rkannoth@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox