2.5.46 & 2.5.47: Errors in drivers/video/aty128fb.c

2.5.46 & 2.5.47: Errors in drivers/video/aty128fb.c

[Priit Laes]

This happens in both versions and when doing make modules and make
bzImage:
gcc -Wp,-MD,drivers/video/.fbgen.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=pentium3 -Iarch/i386/mach-generic -nostdinc -iwithprefixinclude    -DKBUILD_BASENAME=fbgen -DEXPORT_SYMTAB  -c -o drivers/video/fbgen.o drivers/video/fbgen.c
gcc -Wp,-MD,drivers/video/.aty128fb.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=pentium3 -Iarch/i386/mach-generic -nostdinc -iwithprefixinclude    -DKBUILD_BASENAME=aty128fb   -c -o drivers/video/aty128fb.o drivers/video/aty128fb.c
drivers/video/aty128fb.c:419: unknown field `fb_get_fix' specified in initializer
drivers/video/aty128fb.c:419: warning: initialization from incompatible pointer type
drivers/video/aty128fb.c:420: unknown field `fb_get_var' specified in initializer
drivers/video/aty128fb.c:420: warning: initialization from incompatible pointer type
drivers/video/aty128fb.c: In function `aty128fb_set_var':
drivers/video/aty128fb.c:1379: structure has no member named `visual'
drivers/video/aty128fb.c:1380: structure has no member named `type'
drivers/video/aty128fb.c:1381: structure has no member named `type_aux'
drivers/video/aty128fb.c:1382: structure has no member named `ypanstep'
drivers/video/aty128fb.c:1383: structure has no member named `ywrapstep'
drivers/video/aty128fb.c:1384: structure has no member named `line_length'
make[2]: *** [drivers/video/aty128fb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2
    
My configuration is following
# Frame-buffer support
CONFIG_FB=y
CONFIG_DUMMY_CONSOLE=y
CONFIG_FB_VESA=y
CONFIG_FB_ATY128=y
when i tried to compile CONFIG_FB_ATY128 as module it also failed with same errors...
PS. This also happened in 2.5.46, but i didn't bother to report :(

Re: 2.5.46 & 2.5.47: Errors in drivers/video/aty128fb.c

[Benjamin Herrenschmidt]

> My configuration is following
> # Frame-buffer support
> CONFIG_FB=y
> CONFIG_DUMMY_CONSOLE=y
> CONFIG_FB_VESA=y
> CONFIG_FB_ATY128=y
> when i tried to compile CONFIG_FB_ATY128 as module it also failed with same errors...
> PS. This also happened in 2.5.46, but i didn't bother to report :(

There are fixed versions of the aty128 and radeon fb drivers in
the PPC tree. Paulus is now taking care of aty128fb and will probably
send linus and updated version soon. I did a port of radeonfb but have
been waiting for Ani Joshi, the driver's maintainer, to send it to
Linus.

Ben.

Re: 2.5.46 & 2.5.47: Errors in drivers/video/aty128fb.c

[James Simmons]

> > My configuration is following
> > # Frame-buffer support
> > CONFIG_FB=y
> > CONFIG_DUMMY_CONSOLE=y
> > CONFIG_FB_VESA=y
> > CONFIG_FB_ATY128=y
> > when i tried to compile CONFIG_FB_ATY128 as module it also failed with same errors...
> > PS. This also happened in 2.5.46, but i didn't bother to report :(
> 
> There are fixed versions of the aty128 and radeon fb drivers in
> the PPC tree. Paulus is now taking care of aty128fb and will probably
> send linus and updated version soon. I did a port of radeonfb but have
> been waiting for Ani Joshi, the driver's maintainer, to send it to
> Linus.

Ben do you mind if I grab your work and place it in my fbdev BK tree. The 
reason being is there are some more api changes (the last ones) to be 
pushed to linus. 

Re: 2.5.46 & 2.5.47: Errors in drivers/video/aty128fb.c

[Benjamin Herrenschmidt]

> Ben do you mind if I grab your work and place it in my fbdev BK tree. The 
> reason being is there are some more api changes (the last ones) to be 
> pushed to linus. 

Go on, it's in the ppc bk trees (ppc.bkbits.net/linuxppc-2.5 if you can
grab that without auth.)

Ben.