public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* mk712 driver patch
@ 2002-11-18 19:55 Lee Nash
  2002-11-18 23:55 ` [PATHC]mk712 touchscreen " Lee Nash
  0 siblings, 1 reply; 2+ messages in thread
From: Lee Nash @ 2002-11-18 19:55 UTC (permalink / raw)
  To: linux-kernel

Hey,
  I think this is a typo in the mk712 device driver.  It would always
fail even though the region appears in /proc/ioports.  

After this patch, the device works correctly.

Thanks,
-lee

diff -ur linux-2.4.19.orig/drivers/char/mk712.c linux-
2.4.19/drivers/char/mk712.c
--- linux-2.4.19.orig/drivers/char/mk712.c	Fri Aug  2 20:39:43 2002
+++ linux-2.4.19/drivers/char/mk712.c	Mon Nov 18 13:09:59 2002
@@ -439,7 +439,7 @@
                 mk712_irq = irq;
 #endif
 
-	if(request_region(mk712_io, 8, "mk712_touchscreen"))
+	if(!request_region(mk712_io, 8, "mk712_touchscreen"))
 	{
 		printk("mk712: unable to get IO region\n");
 		return -ENODEV;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATHC]mk712 touchscreen driver patch
  2002-11-18 19:55 mk712 driver patch Lee Nash
@ 2002-11-18 23:55 ` Lee Nash
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Nash @ 2002-11-18 23:55 UTC (permalink / raw)
  To: linux-kernel; +Cc: marcelo

Hey,
  I think this is a typo in the mk712 device driver.  It would always
fail even though the region appears in /proc/ioports.

After this patch, the device works correctly.

Thanks,
-lee
(sorry about the double post)

Kernel version 2.4.19 stock

diff -ur linux-2.4.19.orig/drivers/char/mk712.c linux-
2.4.19/drivers/char/mk712.c
--- linux-2.4.19.orig/drivers/char/mk712.c	Fri Aug  2 20:39:43 2002
+++ linux-2.4.19/drivers/char/mk712.c	Mon Nov 18 13:09:59 2002
@@ -439,7 +439,7 @@
                 mk712_irq = irq;
 #endif

-	if(request_region(mk712_io, 8, "mk712_touchscreen"))
+	if(!request_region(mk712_io, 8, "mk712_touchscreen"))
 	{
 		printk("mk712: unable to get IO region\n");
 		return -ENODEV;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-11-18 23:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-11-18 19:55 mk712 driver patch Lee Nash
2002-11-18 23:55 ` [PATHC]mk712 touchscreen " Lee Nash

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox