From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 18 Nov 2002 18:24:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 18 Nov 2002 18:24:40 -0500 Received: from 86.195.27.24.cfl.rr.com ([24.27.195.86]:61846 "EHLO www.compucrew.com") by vger.kernel.org with ESMTP id ; Mon, 18 Nov 2002 18:24:33 -0500 Message-ID: <1037663741.3dd97dfdda29f@www2.compucrew.com> Date: Mon, 18 Nov 2002 18:55:41 -0500 From: Lee Nash To: linux-kernel@vger.kernel.org Cc: marcelo@conectiva.com.br Subject: [PATHC]mk712 touchscreen driver patch References: <1037649307.3dd9459b8997b@www2.compucrew.com> In-Reply-To: <1037649307.3dd9459b8997b@www2.compucrew.com> MIME-Version: 1.0 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) 4.0-cvs Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hey, I think this is a typo in the mk712 device driver. It would always fail even though the region appears in /proc/ioports. After this patch, the device works correctly. Thanks, -lee (sorry about the double post) Kernel version 2.4.19 stock diff -ur linux-2.4.19.orig/drivers/char/mk712.c linux- 2.4.19/drivers/char/mk712.c --- linux-2.4.19.orig/drivers/char/mk712.c Fri Aug 2 20:39:43 2002 +++ linux-2.4.19/drivers/char/mk712.c Mon Nov 18 13:09:59 2002 @@ -439,7 +439,7 @@ mk712_irq = irq; #endif - if(request_region(mk712_io, 8, "mk712_touchscreen")) + if(!request_region(mk712_io, 8, "mk712_touchscreen")) { printk("mk712: unable to get IO region\n"); return -ENODEV;