From: Robert Love <rml@tech9.net>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] printks in drivers/scsi/hosts.c missing return
Date: 13 Dec 2002 21:23:05 -0500 [thread overview]
Message-ID: <1039832585.855.459.camel@phantasy> (raw)
Trivial but annoying: two printk() calls in drivers/scsi/hosts.c are
missing '\n'
Also, for some reason I have not yet investigated, shost_tp->name is
NULL here. This should not be, eh? If it can be, we should do
something to tidy up the printing of it.
Patch is against 2.5.51. Linus, please apply.
Robert Love
drivers/scsi/hosts.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -urN linux-2.5.51-mm1/drivers/scsi/hosts.c linux/drivers/scsi/hosts.c
--- linux-2.5.51-mm1/drivers/scsi/hosts.c 2002-12-10 17:45:02.000000000 -0500
+++ linux/drivers/scsi/hosts.c 2002-12-11 00:40:28.000000000 -0500
@@ -488,14 +488,14 @@
if (!shost_tp->max_sectors) {
printk(KERN_WARNING
"scsi HBA driver %s didn't set max_sectors, "
- "please fix the template", shost_tp->name);
+ "please fix the template\n", shost_tp->name);
shost_tp->max_sectors = 1024;
}
if (!shost_tp->release) {
printk(KERN_WARNING
"scsi HBA driver %s didn't set a release method, "
- "please fix the template", shost_tp->name);
+ "please fix the template\n", shost_tp->name);
shost_tp->release = &scsi_host_legacy_release;
}
next reply other threads:[~2002-12-14 2:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-14 2:23 Robert Love [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-12-11 5:55 [PATCH] printks in drivers/scsi/hosts.c missing return Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1039832585.855.459.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox