public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Scorpion <scorpionlab@ieg.com.br>
To: linux-kernel@vger.kernel.org
Subject: USB/Storage - transport.c - Olympus D150Zoom
Date: 21 Dec 2002 01:31:23 -0200	[thread overview]
Message-ID: <1040441486.3708.25.camel@beyond> (raw)



Hi,
I was trying to put my digital camera Olympus Brio Zoom D-150Zoom
to work on my RedHat 7.3 (2.4.18-3, redhat) when found this web page:
http://www.gingerbear.org/~esm/olympus/

Clicking on transport.c.diff link and taking a look into
/usr/src/linux-2.4.18-3/drivers/usb/storage/transport.c file
I started to ask my self what is doing the
if (bcs.Signature != cpu_to_le32(US_BULK_CS_SIGN) ||
statement there? Please if anyone could, answer me...
The patch applied to "support" this camera just remove this comparison,
so what it does?

Best regards,
Scorpion.
---------------transport.c.diff----------------
--- drivers/usb/storage/transport.c	2002/08/07 13:14:59	1.1
+++ drivers/usb/storage/transport.c	2002/08/07 13:15:08
@@ -1197,8 +1197,7 @@
 	US_DEBUGP("Bulk status Sig 0x%x T 0x%x R %d Stat 0x%x\n",
 		  le32_to_cpu(bcs.Signature), bcs.Tag, 
 		  bcs.Residue, bcs.Status);
-	if (bcs.Signature != cpu_to_le32(US_BULK_CS_SIGN) || 
-	    bcs.Tag != bcb.Tag || 
+	if (bcs.Tag != bcb.Tag || 
 	    bcs.Status > US_BULK_STAT_PHASE || partial != 13) {
 		US_DEBUGP("Bulk logical error\n");
 		return USB_STOR_TRANSPORT_ERROR;
---------------transport.c.diff----------------



                 reply	other threads:[~2002-12-21  4:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1040441486.3708.25.camel@beyond \
    --to=scorpionlab@ieg.com.br \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox